Reset TexImage2D base level to workaround Intel mac driver bug

gpu/command_buffer/service/texture_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/texture_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 3243 matching lines @@
   {
     ScopedTextureUploadTimer timer(texture_state);
     if (args.command_type == DoTexImageArguments::kTexImage3D) {
       glTexImage3D(
           args.target, args.level,
           AdjustTexInternalFormat(feature_info_.get(), args.internal_format),
           args.width, args.height, args.depth, args.border,
           AdjustTexFormat(feature_info_.get(), args.format), args.type,
           args.pixels);
     } else {
+      if (feature_info_->workarounds().reset_teximage2d_base_level) {
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 0);

[Ken Russell (switch to Gerrit), 2017/04/28 19:04:25]

Does this have the correct effect in all cases? The glTexImage2D call below
refers to args.target, not GL_TEXTURE_2D. Is this necessary even when
args.target != GL_TEXTURE_2D?

[yizhou.jiang, 2017/06/09 07:58:16]

No, I have only investigated GL_TEXTURE_2D, I will add check if args.target is
GL_TEXTURE_2D.

+      }
       glTexImage2D(
           args.target, args.level,
           AdjustTexInternalFormat(feature_info_.get(), args.internal_format),
           args.width, args.height, args.border,
           AdjustTexFormat(feature_info_.get(), args.format), args.type,
           args.pixels);
+      if (feature_info_->workarounds().reset_teximage2d_base_level) {
+        Texture* texture = texture_ref->texture();
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL,
+                        texture->base_level());
+      }
     }
   }
   GLenum error = ERRORSTATE_PEEK_GL_ERROR(error_state, function_name);
   if (args.command_type == DoTexImageArguments::kTexImage3D) {
     UMA_HISTOGRAM_CUSTOM_ENUMERATION("GPU.Error_TexImage3D", error,
         GetAllGLErrors());
   } else {
     UMA_HISTOGRAM_CUSTOM_ENUMERATION("GPU.Error_TexImage2D", error,
         GetAllGLErrors());
   }
@@ skipping 404 matching lines @@
 uint32_t TextureManager::GetServiceIdGeneration() const {
   return current_service_id_generation_;
 }
 
 void TextureManager::IncrementServiceIdGeneration() {
   current_service_id_generation_++;
 }
 
 }  // namespace gles2
 }  // namespace gpu