Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2827543006: Make zero-termination optional. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Minor problems found during testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M pkg/front_end/lib/src/fasta/io.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/io.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/translate_uri.dart View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 8 months ago (2017-04-19 13:09:59 UTC) #2
Paul Berry
lgtm
3 years, 8 months ago (2017-04-19 13:17:54 UTC) #3
ahe
3 years, 8 months ago (2017-04-19 13:29:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0ceb30a5e015626a73998766d14912b4dcb828b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698