Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: content/public/browser/browsing_data_remover.h

Issue 2827523003: Move BrowsingDataRemover to content/ (Closed)
Patch Set: Rebase over codereview.chromium.org/2815913005 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/browser_context.h ('k') | content/public/browser/browsing_data_remover_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/content/public/browser/browsing_data_remover.h
similarity index 87%
rename from chrome/browser/browsing_data/browsing_data_remover.h
rename to content/public/browser/browsing_data_remover.h
index 757d8a8af6ade18ddbea5640c63103905df90a25..6414b2895dfb8ea374f48c0aee87be1f45479104 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.h
+++ b/content/public/browser/browsing_data_remover.h
@@ -2,20 +2,26 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
-#define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
+#ifndef CONTENT_PUBLIC_BROWSER_BROWSING_DATA_REMOVER_H_
+#define CONTENT_PUBLIC_BROWSER_BROWSING_DATA_REMOVER_H_
#include <memory>
+
#include "base/callback_forward.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
#include "build/build_config.h"
-#include "chrome/browser/browsing_data/browsing_data_remover_delegate.h"
-#include "components/keyed_service/core/keyed_service.h"
+
+class GURL;
+
+namespace storage {
+class SpecialStoragePolicy;
+}
namespace content {
+
class BrowsingDataFilterBuilder;
-}
+class BrowsingDataRemoverDelegate;
////////////////////////////////////////////////////////////////////////////////
// BrowsingDataRemover is responsible for removing data related to browsing:
@@ -25,8 +31,8 @@ class BrowsingDataFilterBuilder;
//
// 0. Instantiation.
//
-// BrowsingDataRemover* remover =
-// BrowsingDataRemoverFactory::GetForBrowserContext(browser_context);
+// content::BrowsingDataRemover* remover =
+// content::BrowserContext::GetBrowsingDataRemover(browser_context);
//
// 1. No observer.
//
@@ -34,7 +40,7 @@ class BrowsingDataFilterBuilder;
//
// 2. Using an observer to report when one's own removal task is finished.
//
-// class CookiesDeleter : public BrowsingDataRemover::Observer {
+// class CookiesDeleter : public content::BrowsingDataRemover::Observer {
// CookiesDeleter() { remover->AddObserver(this); }
// ~CookiesDeleter() { remover->RemoveObserver(this); }
//
@@ -52,7 +58,7 @@ class BrowsingDataFilterBuilder;
//
// TODO(crbug.com/668114): BrowsingDataRemover does not currently support plugin
// data deletion. Use PluginDataRemover instead.
-class BrowsingDataRemover : public KeyedService {
+class BrowsingDataRemover {
public:
// Mask used for Remove.
enum DataType {
@@ -128,11 +134,9 @@ class BrowsingDataRemover : public KeyedService {
virtual ~Observer() {}
};
- // Called by the embedder to provide the delegate that will take care of
- // deleting embedder-specific data.
+ // A delegate that will take care of deleting embedder-specific data.
virtual void SetEmbedderDelegate(
- std::unique_ptr<BrowsingDataRemoverDelegate> embedder_delegate) = 0;
- virtual BrowsingDataRemoverDelegate* GetEmbedderDelegate() const = 0;
+ BrowsingDataRemoverDelegate* embedder_delegate) = 0;
// Determines whether |origin| matches the |origin_type_mask| according to
// the |special_storage_policy|.
@@ -164,7 +168,7 @@ class BrowsingDataRemover : public KeyedService {
const base::Time& delete_end,
int remove_mask,
int origin_type_mask,
- std::unique_ptr<content::BrowsingDataFilterBuilder> filter_builder) = 0;
+ std::unique_ptr<BrowsingDataFilterBuilder> filter_builder) = 0;
// A version of the above that in addition informs the |observer| when the
// removal task is finished.
@@ -173,7 +177,7 @@ class BrowsingDataRemover : public KeyedService {
const base::Time& delete_end,
int remove_mask,
int origin_type_mask,
- std::unique_ptr<content::BrowsingDataFilterBuilder> filter_builder,
+ std::unique_ptr<BrowsingDataFilterBuilder> filter_builder,
Observer* observer) = 0;
// Observers.
@@ -200,4 +204,6 @@ class BrowsingDataRemover : public KeyedService {
virtual int GetLastUsedOriginTypeMask() = 0;
};
-#endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
+} // namespace content
+
+#endif // CONTENT_PUBLIC_BROWSER_BROWSING_DATA_REMOVER_H_
« no previous file with comments | « content/public/browser/browser_context.h ('k') | content/public/browser/browsing_data_remover_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698