Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2827453003: Fix for issue 29350 - VM Crashes when covariant is used incorrectly. (Closed)

Created:
3 years, 8 months ago by siva
Modified:
3 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 29350 - VM Crashes when covariant is used incorrectly. BUG=#29350 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/96bbe512eb1a026e17aff584b51648c15b6f4bd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M runtime/vm/object.h View 2 chunks +5 lines, -0 lines 0 comments Download
A tests/standalone/regress_29350_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
3 years, 8 months ago (2017-04-18 00:02:00 UTC) #2
rmacnak
lgtm
3 years, 8 months ago (2017-04-18 00:14:45 UTC) #3
siva
3 years, 8 months ago (2017-04-18 18:10:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96bbe512eb1a026e17aff584b51648c15b6f4bd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698