Source/platform/mac/ScrollElasticityController.mm - Issue 282743002: Fix page jumping back to initial position after an overflow-bounce scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/mac/ScrollElasticityController.mm

Issue 282743002: Fix page jumping back to initial position after an overflow-bounce scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove whitespace from TestExpectations that was causing a rebase failure. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/mac/ScrollElasticityController.mm

diff --git a/Source/platform/mac/ScrollElasticityController.mm b/Source/platform/mac/ScrollElasticityController.mm

index 0ab305b6ab91823e3ff09e4e30feebf082a77ac4..2a78c271c290279388db28ab8dbcc5c5b12b36a5 100644

--- a/Source/platform/mac/ScrollElasticityController.mm

+++ b/Source/platform/mac/ScrollElasticityController.mm

@@ -357,7 +357,7 @@ void ScrollElasticityController::snapRubberBandTimerFired()

m_stretchScrollForce.setWidth(reboundDeltaForElasticDelta(newStretch.width()));

m_stretchScrollForce.setHeight(reboundDeltaForElasticDelta(newStretch.height()));

} else {

- m_client->immediateScrollBy(m_origOrigin - m_client->absoluteScrollPosition());

+ m_client->adjustScrollPositionToBoundsIfNecessary();

stopSnapRubberbandTimer();

m_stretchScrollForce = FloatSize();

« no previous file with comments | « Source/platform/mac/ScrollElasticityController.h ('k') | no next file » | no next file with comments »