Source/platform/mac/ScrollAnimatorMac.h - Issue 282743002: Fix page jumping back to initial position after an overflow-bounce scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/mac/ScrollAnimatorMac.h

Issue 282743002: Fix page jumping back to initial position after an overflow-bounce scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove whitespace from TestExpectations that was causing a rebase failure. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/mac/ScrollAnimatorMac.h

diff --git a/Source/platform/mac/ScrollAnimatorMac.h b/Source/platform/mac/ScrollAnimatorMac.h

index d893982f0133c14e2e79c19dabe7186c64f57441..d0bf6cc8f1a5d9558fda9066bbb61e536e3772e1 100644

--- a/Source/platform/mac/ScrollAnimatorMac.h

+++ b/Source/platform/mac/ScrollAnimatorMac.h

@@ -143,6 +143,7 @@ private:

virtual void immediateScrollBy(const FloatSize&) OVERRIDE;

virtual void startSnapRubberbandTimer() OVERRIDE;

virtual void stopSnapRubberbandTimer() OVERRIDE;

+ virtual void adjustScrollPositionToBoundsIfNecessary() OVERRIDE;

bool pinnedInDirection(float deltaX, float deltaY);

void snapRubberBandTimerFired(Timer<ScrollAnimatorMac>*);

« no previous file with comments | « LayoutTests/rubberbanding/scroll-bounce-fix.html ('k') | Source/platform/mac/ScrollAnimatorMac.mm » ('j') | no next file with comments »