Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2827363003: Disable flaky tests in PrerenderingOfflinerTest. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h" 5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 } 249 }
250 250
251 void PrerenderingOfflinerTest::OnProgress(const SavePageRequest& request, 251 void PrerenderingOfflinerTest::OnProgress(const SavePageRequest& request,
252 int64_t bytes) {} 252 int64_t bytes) {}
253 253
254 void PrerenderingOfflinerTest::OnCancel(int64_t offline_id) { 254 void PrerenderingOfflinerTest::OnCancel(int64_t offline_id) {
255 DCHECK(!cancel_callback_called_); 255 DCHECK(!cancel_callback_called_);
256 cancel_callback_called_ = true; 256 cancel_callback_called_ = true;
257 } 257 }
258 258
259 TEST_F(PrerenderingOfflinerTest, LoadAndSaveBadUrl) { 259 TEST_F(PrerenderingOfflinerTest, DISABLED_LoadAndSaveBadUrl) {
260 base::Time creation_time = base::Time::Now(); 260 base::Time creation_time = base::Time::Now();
261 SavePageRequest request( 261 SavePageRequest request(
262 kRequestId, kFileUrl, kClientId, creation_time, kUserRequested); 262 kRequestId, kFileUrl, kClientId, creation_time, kUserRequested);
263 EXPECT_FALSE(offliner()->LoadAndSave(request, completion_callback(), 263 EXPECT_FALSE(offliner()->LoadAndSave(request, completion_callback(),
264 progress_callback())); 264 progress_callback()));
265 EXPECT_TRUE(loader()->IsIdle()); 265 EXPECT_TRUE(loader()->IsIdle());
266 } 266 }
267 267
268 TEST_F(PrerenderingOfflinerTest, LoadAndSavePrerenderingDisabled) { 268 TEST_F(PrerenderingOfflinerTest, DISABLED_LoadAndSavePrerenderingDisabled) {
269 base::Time creation_time = base::Time::Now(); 269 base::Time creation_time = base::Time::Now();
270 SavePageRequest request( 270 SavePageRequest request(
271 kRequestId, kHttpUrl, kClientId, creation_time, kUserRequested); 271 kRequestId, kHttpUrl, kClientId, creation_time, kUserRequested);
272 loader()->DisablePrerendering(); 272 loader()->DisablePrerendering();
273 EXPECT_FALSE(offliner()->LoadAndSave(request, completion_callback(), 273 EXPECT_FALSE(offliner()->LoadAndSave(request, completion_callback(),
274 progress_callback())); 274 progress_callback()));
275 EXPECT_TRUE(loader()->IsIdle()); 275 EXPECT_TRUE(loader()->IsIdle());
276 } 276 }
277 277
278 TEST_F(PrerenderingOfflinerTest, 278 TEST_F(PrerenderingOfflinerTest,
279 LoadAndSaveBlockThirdPartyCookiesForCustomTabs) { 279 DISABLED_LoadAndSaveBlockThirdPartyCookiesForCustomTabs) {
280 base::Time creation_time = base::Time::Now(); 280 base::Time creation_time = base::Time::Now();
281 ClientId custom_tabs_client_id("custom_tabs", "88"); 281 ClientId custom_tabs_client_id("custom_tabs", "88");
282 SavePageRequest request(kRequestId, kHttpUrl, custom_tabs_client_id, 282 SavePageRequest request(kRequestId, kHttpUrl, custom_tabs_client_id,
283 creation_time, kUserRequested); 283 creation_time, kUserRequested);
284 profile()->GetPrefs()->SetBoolean(prefs::kBlockThirdPartyCookies, true); 284 profile()->GetPrefs()->SetBoolean(prefs::kBlockThirdPartyCookies, true);
285 EXPECT_FALSE(offliner()->LoadAndSave(request, completion_callback(), 285 EXPECT_FALSE(offliner()->LoadAndSave(request, completion_callback(),
286 progress_callback())); 286 progress_callback()));
287 EXPECT_TRUE(loader()->IsIdle()); 287 EXPECT_TRUE(loader()->IsIdle());
288 } 288 }
289 289
290 TEST_F(PrerenderingOfflinerTest, 290 TEST_F(PrerenderingOfflinerTest,
291 LoadAndSaveBlockOnDisabledPrerendererForCustomTabs) { 291 DISABLED_LoadAndSaveBlockOnDisabledPrerendererForCustomTabs) {
292 base::Time creation_time = base::Time::Now(); 292 base::Time creation_time = base::Time::Now();
293 ClientId custom_tabs_client_id("custom_tabs", "88"); 293 ClientId custom_tabs_client_id("custom_tabs", "88");
294 SavePageRequest request(kRequestId, kHttpUrl, custom_tabs_client_id, 294 SavePageRequest request(kRequestId, kHttpUrl, custom_tabs_client_id,
295 creation_time, kUserRequested); 295 creation_time, kUserRequested);
296 profile()->GetPrefs()->SetInteger( 296 profile()->GetPrefs()->SetInteger(
297 prefs::kNetworkPredictionOptions, 297 prefs::kNetworkPredictionOptions,
298 chrome_browser_net::NETWORK_PREDICTION_NEVER); 298 chrome_browser_net::NETWORK_PREDICTION_NEVER);
299 EXPECT_FALSE(offliner()->LoadAndSave(request, completion_callback(), 299 EXPECT_FALSE(offliner()->LoadAndSave(request, completion_callback(),
300 progress_callback())); 300 progress_callback()));
301 EXPECT_TRUE(loader()->IsIdle()); 301 EXPECT_TRUE(loader()->IsIdle());
302 } 302 }
303 303
304 TEST_F(PrerenderingOfflinerTest, LoadAndSaveLoadStartedButFails) { 304 TEST_F(PrerenderingOfflinerTest, DISABLED_LoadAndSaveLoadStartedButFails) {
305 base::Time creation_time = base::Time::Now(); 305 base::Time creation_time = base::Time::Now();
306 SavePageRequest request( 306 SavePageRequest request(
307 kRequestId, kHttpUrl, kClientId, creation_time, kUserRequested); 307 kRequestId, kHttpUrl, kClientId, creation_time, kUserRequested);
308 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(), 308 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
309 progress_callback())); 309 progress_callback()));
310 EXPECT_FALSE(loader()->IsIdle()); 310 EXPECT_FALSE(loader()->IsIdle());
311 EXPECT_EQ(Offliner::RequestStatus::UNKNOWN, request_status()); 311 EXPECT_EQ(Offliner::RequestStatus::UNKNOWN, request_status());
312 312
313 loader()->CompleteLoadingAsFailed(); 313 loader()->CompleteLoadingAsFailed();
314 PumpLoop(); 314 PumpLoop();
315 EXPECT_TRUE(completion_callback_called()); 315 EXPECT_TRUE(completion_callback_called());
316 EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED, request_status()); 316 EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED, request_status());
317 EXPECT_TRUE(loader()->IsIdle()); 317 EXPECT_TRUE(loader()->IsIdle());
318 EXPECT_FALSE(SaveInProgress()); 318 EXPECT_FALSE(SaveInProgress());
319 } 319 }
320 320
321 TEST_F(PrerenderingOfflinerTest, CancelWhenLoading) { 321 TEST_F(PrerenderingOfflinerTest, DISABLED_CancelWhenLoading) {
322 base::Time creation_time = base::Time::Now(); 322 base::Time creation_time = base::Time::Now();
323 SavePageRequest request( 323 SavePageRequest request(
324 kRequestId, kHttpUrl, kClientId, creation_time, kUserRequested); 324 kRequestId, kHttpUrl, kClientId, creation_time, kUserRequested);
325 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(), 325 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
326 progress_callback())); 326 progress_callback()));
327 EXPECT_FALSE(loader()->IsIdle()); 327 EXPECT_FALSE(loader()->IsIdle());
328 328
329 offliner()->Cancel(cancel_callback()); 329 offliner()->Cancel(cancel_callback());
330 PumpLoop(); 330 PumpLoop();
331 EXPECT_TRUE(cancel_callback_called()); 331 EXPECT_TRUE(cancel_callback_called());
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 426
427 loader()->CompleteLoadingAsCanceled(); 427 loader()->CompleteLoadingAsCanceled();
428 PumpLoop(); 428 PumpLoop();
429 EXPECT_TRUE(completion_callback_called()); 429 EXPECT_TRUE(completion_callback_called());
430 EXPECT_EQ(Offliner::RequestStatus::LOADING_CANCELED, request_status()); 430 EXPECT_EQ(Offliner::RequestStatus::LOADING_CANCELED, request_status());
431 EXPECT_FALSE(loader()->IsLoaded()); 431 EXPECT_FALSE(loader()->IsLoaded());
432 // Note: save still in progress since it does not support canceling. 432 // Note: save still in progress since it does not support canceling.
433 EXPECT_TRUE(SaveInProgress()); 433 EXPECT_TRUE(SaveInProgress());
434 } 434 }
435 435
436 TEST_F(PrerenderingOfflinerTest, ForegroundTransitionCancelsOnLowEndDevice) { 436 TEST_F(PrerenderingOfflinerTest,
437 DISABLED_ForegroundTransitionCancelsOnLowEndDevice) {
437 offliner()->SetLowEndDeviceForTesting(true); 438 offliner()->SetLowEndDeviceForTesting(true);
438 439
439 base::Time creation_time = base::Time::Now(); 440 base::Time creation_time = base::Time::Now();
440 SavePageRequest request( 441 SavePageRequest request(
441 kRequestId, kHttpUrl, kClientId, creation_time, kUserRequested); 442 kRequestId, kHttpUrl, kClientId, creation_time, kUserRequested);
442 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(), 443 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
443 progress_callback())); 444 progress_callback()));
444 EXPECT_FALSE(loader()->IsIdle()); 445 EXPECT_FALSE(loader()->IsIdle());
445 446
446 offliner()->SetApplicationStateForTesting( 447 offliner()->SetApplicationStateForTesting(
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 kUserRequested); 500 kUserRequested);
500 request.set_completed_attempt_count(policy()->GetMaxCompletedTries() - 1); 501 request.set_completed_attempt_count(policy()->GetMaxCompletedTries() - 1);
501 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(), 502 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
502 progress_callback())); 503 progress_callback()));
503 loader()->set_is_lowbar_met(true); 504 loader()->set_is_lowbar_met(true);
504 EXPECT_TRUE(offliner()->HandleTimeout(request)); 505 EXPECT_TRUE(offliner()->HandleTimeout(request));
505 EXPECT_TRUE(loader()->start_snapshot_called()); 506 EXPECT_TRUE(loader()->start_snapshot_called());
506 } 507 }
507 508
508 TEST_F(PrerenderingOfflinerTest, 509 TEST_F(PrerenderingOfflinerTest,
509 HandleTimeoutCompletedTriesMetWithoutLowbarMet) { 510 DISABLED_HandleTimeoutCompletedTriesMetWithoutLowbarMet) {
510 offliner()->SetLowEndDeviceForTesting(false); 511 offliner()->SetLowEndDeviceForTesting(false);
511 512
512 base::Time creation_time = base::Time::Now(); 513 base::Time creation_time = base::Time::Now();
513 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time, 514 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time,
514 kUserRequested); 515 kUserRequested);
515 request.set_completed_attempt_count(policy()->GetMaxCompletedTries() - 1); 516 request.set_completed_attempt_count(policy()->GetMaxCompletedTries() - 1);
516 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(), 517 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
517 progress_callback())); 518 progress_callback()));
518 loader()->set_is_lowbar_met(false); 519 loader()->set_is_lowbar_met(false);
519 EXPECT_FALSE(offliner()->HandleTimeout(request)); 520 EXPECT_FALSE(offliner()->HandleTimeout(request));
520 EXPECT_FALSE(loader()->start_snapshot_called()); 521 EXPECT_FALSE(loader()->start_snapshot_called());
521 } 522 }
522 523
523 TEST_F(PrerenderingOfflinerTest, HandleTimeoutStartedTriesMetWithoutLowbarMet) { 524 TEST_F(PrerenderingOfflinerTest,
525 DISABLED_HandleTimeoutStartedTriesMetWithoutLowbarMet) {
524 offliner()->SetLowEndDeviceForTesting(false); 526 offliner()->SetLowEndDeviceForTesting(false);
525 527
526 base::Time creation_time = base::Time::Now(); 528 base::Time creation_time = base::Time::Now();
527 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time, 529 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time,
528 kUserRequested); 530 kUserRequested);
529 request.set_started_attempt_count(policy()->GetMaxStartedTries() - 1); 531 request.set_started_attempt_count(policy()->GetMaxStartedTries() - 1);
530 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(), 532 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
531 progress_callback())); 533 progress_callback()));
532 loader()->set_is_lowbar_met(false); 534 loader()->set_is_lowbar_met(false);
533 EXPECT_FALSE(offliner()->HandleTimeout(request)); 535 EXPECT_FALSE(offliner()->HandleTimeout(request));
534 EXPECT_FALSE(loader()->start_snapshot_called()); 536 EXPECT_FALSE(loader()->start_snapshot_called());
535 } 537 }
536 538
537 TEST_F(PrerenderingOfflinerTest, HandleTimeoutWithLowbarAndStartedTriesMet) { 539 TEST_F(PrerenderingOfflinerTest, HandleTimeoutWithLowbarAndStartedTriesMet) {
538 offliner()->SetLowEndDeviceForTesting(false); 540 offliner()->SetLowEndDeviceForTesting(false);
539 541
540 base::Time creation_time = base::Time::Now(); 542 base::Time creation_time = base::Time::Now();
541 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time, 543 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time,
542 kUserRequested); 544 kUserRequested);
543 request.set_started_attempt_count(policy()->GetMaxStartedTries() - 1); 545 request.set_started_attempt_count(policy()->GetMaxStartedTries() - 1);
544 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(), 546 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
545 progress_callback())); 547 progress_callback()));
546 loader()->set_is_lowbar_met(true); 548 loader()->set_is_lowbar_met(true);
547 EXPECT_TRUE(offliner()->HandleTimeout(request)); 549 EXPECT_TRUE(offliner()->HandleTimeout(request));
548 EXPECT_TRUE(loader()->start_snapshot_called()); 550 EXPECT_TRUE(loader()->start_snapshot_called());
549 } 551 }
550 552
551 TEST_F(PrerenderingOfflinerTest, HandleTimeoutWithOnlyLowbarMet) { 553 TEST_F(PrerenderingOfflinerTest, DISABLED_HandleTimeoutWithOnlyLowbarMet) {
552 offliner()->SetLowEndDeviceForTesting(false); 554 offliner()->SetLowEndDeviceForTesting(false);
553 555
554 base::Time creation_time = base::Time::Now(); 556 base::Time creation_time = base::Time::Now();
555 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time, 557 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time,
556 kUserRequested); 558 kUserRequested);
557 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(), 559 EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
558 progress_callback())); 560 progress_callback()));
559 loader()->set_is_lowbar_met(true); 561 loader()->set_is_lowbar_met(true);
560 EXPECT_FALSE(offliner()->HandleTimeout(request)); 562 EXPECT_FALSE(offliner()->HandleTimeout(request));
561 EXPECT_FALSE(loader()->start_snapshot_called()); 563 EXPECT_FALSE(loader()->start_snapshot_called());
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
608 PumpLoop(); 610 PumpLoop();
609 EXPECT_EQ(Offliner::RequestStatus::SAVED, request_status()); 611 EXPECT_EQ(Offliner::RequestStatus::SAVED, request_status());
610 612
611 // One extra part should be added if the flag is on. 613 // One extra part should be added if the flag is on.
612 content::MHTMLExtraParts* extra_parts = 614 content::MHTMLExtraParts* extra_parts =
613 content::MHTMLExtraParts::FromWebContents(loader()->web_contents()); 615 content::MHTMLExtraParts::FromWebContents(loader()->web_contents());
614 EXPECT_EQ(extra_parts->size(), 1); 616 EXPECT_EQ(extra_parts->size(), 1);
615 } 617 }
616 618
617 } // namespace offline_pages 619 } // namespace offline_pages
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698