Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2960)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java

Issue 2827363002: 📰 Fix tile icon rendering issue in Chrome Home (Closed)
Patch Set: rebase and address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
index c5630347584a75e001a2bdf5e93f86ecd7f6aba6..83c4d2129100d0819aa60a6fcaca0f498fb82f56 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
@@ -66,6 +66,12 @@ protected void notifyItemChanged(int index, @Nullable PartialBindCallback callba
notifyItemRangeChanged(index, 1, callback);
}
+ /**
+ * @deprecated Change notifications without payload recreate the view holder. Is that on
+ * purpose? Use {@link #notifyItemChanged(int, PartialBindCallback)} if the item to be notified
+ * should not be entirely replaced. (see https://crbug.com/704130)
+ */
+ @Deprecated // Can be valid in specific cases, but marked as deprecated to provide the warning.
protected void notifyItemChanged(int index) {
notifyItemRangeChanged(index, 1);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698