Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

Issue 2827333005: Moving overhead counting to bitrate estimators.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
index 961b53a139c3901984ee907fc10d491a68210b3a..3e715fbc37f896bdadc1af478f3929dea302a85c 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
@@ -126,8 +126,9 @@ class MockSendPacketObserver : public SendPacketObserver {
class MockTransportFeedbackObserver : public TransportFeedbackObserver {
public:
- MOCK_METHOD4(AddPacket,
- void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
+ MOCK_METHOD5(
+ AddPacket,
+ void(uint32_t, uint16_t, size_t, size_t, const PacedPacketInfo&));
MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
};
@@ -362,14 +363,10 @@ TEST_P(RtpSenderTestWithoutPacer,
EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
.WillOnce(testing::Return(kTransportSequenceNumber));
- const size_t expected_bytes =
- GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
- kRtpOverheadBytesPerPacket
- : sizeof(kPayloadData) + kGenericHeaderLength;
-
EXPECT_CALL(feedback_observer_,
AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
- expected_bytes, PacedPacketInfo()))
+ sizeof(kPayloadData) + kGenericHeaderLength,
+ kRtpOverheadBytesPerPacket, PacedPacketInfo()))
.Times(1);
EXPECT_CALL(mock_overhead_observer,
OnOverheadChanged(kRtpOverheadBytesPerPacket))
@@ -394,7 +391,7 @@ TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
.Times(1);
EXPECT_CALL(feedback_observer_,
- AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
+ AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _, _,
PacedPacketInfo()))
.Times(1);
@@ -444,7 +441,7 @@ TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
OnSendPacket(kTransportSequenceNumber, _, _))
.Times(1);
EXPECT_CALL(feedback_observer_,
- AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
+ AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _, _,
PacedPacketInfo()))
.Times(1);

Powered by Google App Engine
This is Rietveld 408576698