Moving overhead counting to bitrate estimators.

webrtc/modules/congestion_controller/include/congestion_controller.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 106 matching lines @@
   // Implements CallStatsObserver.
   void OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms) override;
 
   // Implements Module.
   int64_t TimeUntilNextProcess() override;
   void Process() override;
 
   // Implements TransportFeedbackObserver.
   void AddPacket(uint32_t ssrc,
                  uint16_t sequence_number,
-                 size_t length,
+                 size_t payload_size,
+                 size_t rtp_headers_size,

[stefan-webrtc, 2017/04/21 12:35:27]

I don't like this since I want to move towards CongestionController being
transport agnostic. We shouldn't know about RTP here.

[minyue-webrtc, 2017/04/21 12:58:14]

I know that and would like to avoid this. But the superclass
TransportFeedbackObserver is defined in rtp_rtcp. Any suggestions?

                  const PacedPacketInfo& pacing_info) override;
   void OnTransportFeedback(const rtcp::TransportFeedback& feedback) override;
   std::vector<PacketFeedback> GetTransportFeedbackVector() const override;
 
  private:
   SendSideCongestionController send_side_cc_;
   ReceiveSideCongestionController receive_side_cc_;
 
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(CongestionController);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_CONGESTION_CONTROLLER_H_