Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2827333003: Tighten up handling of JS types and add test. (Closed)
Patch Set: Tighten up handling of JS types. Fix bug where helpers in js_mirrors were specifying name had type … Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], 5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
6 function(dart_sdk, async_helper, expect, unittest, is, require) { 6 function(dart_sdk, async_helper, expect, unittest, is, require) {
7 'use strict'; 7 'use strict';
8 8
9 async_helper = async_helper.async_helper; 9 async_helper = async_helper.async_helper;
10 let minitest = expect.minitest; 10 let minitest = expect.minitest;
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 'indexeddb_5_test': async_unittest, 495 'indexeddb_5_test': async_unittest,
496 496
497 // was https://github.com/dart-lang/sdk/issues/27578, needs triage 497 // was https://github.com/dart-lang/sdk/issues/27578, needs triage
498 'input_element_test': 'fail', 498 'input_element_test': 'fail',
499 499
500 'interactive_test': async_unittest, 500 'interactive_test': async_unittest,
501 'isolates_test': async_unittest, 501 'isolates_test': async_unittest,
502 502
503 'js_interop_1_test': async_unittest, 503 'js_interop_1_test': async_unittest,
504 504
505 // Failing because accessing "zSomeInvalidName" does not throw.
506 'js_typed_interop_test': 'fail',
507
508 // The "typed literal" test fails because the object does not have "_c". 505 // The "typed literal" test fails because the object does not have "_c".
509 'js_util_test': 'fail', 506 'js_util_test': 'fail',
510 'keyboard_event_test': async_unittest, 507 'keyboard_event_test': async_unittest,
511 508
512 // was https://github.com/dart-lang/sdk/issues/27578, needs triage 509 // was https://github.com/dart-lang/sdk/issues/27578, needs triage
513 'mediasource_test': 'fail', 510 'mediasource_test': 'fail',
514 'media_stream_test': 'fail', 511 'media_stream_test': 'fail',
515 512
516 // https://github.com/dart-lang/sdk/issues/29071 513 // https://github.com/dart-lang/sdk/issues/29071
517 'messageevent_test': firefox_fail, 514 'messageevent_test': firefox_fail,
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 959
963 for (let action of unittest_tests) { 960 for (let action of unittest_tests) {
964 try { 961 try {
965 action(); 962 action();
966 } catch (e) { 963 } catch (e) {
967 console.error("Caught error tying to setup test:", e); 964 console.error("Caught error tying to setup test:", e);
968 } 965 }
969 } 966 }
970 }); 967 });
971 }); 968 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698