Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/task_manager/sampling/task_manager_impl.h

Issue 2827323002: gpu:: Remove GpuDataManagerObserver::OnVideoMemoryUsageStatsUpdate(). (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/task_manager/sampling/task_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/sampling/task_manager_impl.h
diff --git a/chrome/browser/task_manager/sampling/task_manager_impl.h b/chrome/browser/task_manager/sampling/task_manager_impl.h
index e910867d873a620cfd34da9a316b6dc98e04a6f6..b483494326c315aa64dd414f5d77358422e6d75f 100644
--- a/chrome/browser/task_manager/sampling/task_manager_impl.h
+++ b/chrome/browser/task_manager/sampling/task_manager_impl.h
@@ -15,6 +15,7 @@
#include "base/lazy_instance.h"
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "base/sequenced_task_runner.h"
#include "base/time/time.h"
#include "chrome/browser/task_manager/providers/task_provider.h"
@@ -22,7 +23,6 @@
#include "chrome/browser/task_manager/sampling/task_group.h"
#include "chrome/browser/task_manager/sampling/task_manager_io_thread_helper.h"
#include "chrome/browser/task_manager/task_manager_interface.h"
-#include "content/public/browser/gpu_data_manager_observer.h"
#include "gpu/ipc/common/memory_stats.h"
namespace task_manager {
@@ -30,10 +30,8 @@ namespace task_manager {
class SharedSampler;
// Defines a concrete implementation of the TaskManagerInterface.
-class TaskManagerImpl :
- public TaskManagerInterface,
- public TaskProviderObserver,
- content::GpuDataManagerObserver {
+class TaskManagerImpl : public TaskManagerInterface,
+ public TaskProviderObserver {
public:
~TaskManagerImpl() override;
@@ -96,10 +94,6 @@ class TaskManagerImpl :
void TaskRemoved(Task* task) override;
void TaskUnresponsive(Task* task) override;
- // content::GpuDataManagerObserver:
- void OnVideoMemoryUsageStatsUpdate(
- const gpu::VideoMemoryUsageStats& gpu_memory_stats) override;
-
// The notification method on the UI thread when multiple bytes are read
// from URLRequests. This will be called by the |io_thread_helper_|
static void OnMultipleBytesReadUI(std::vector<BytesReadParam>* params);
@@ -109,6 +103,9 @@ class TaskManagerImpl :
TaskManagerImpl();
+ void OnVideoMemoryUsageStatsUpdate(
+ const gpu::VideoMemoryUsageStats& gpu_memory_stats);
+
// task_manager::TaskManagerInterface:
void Refresh() override;
void StartUpdating() override;
@@ -169,6 +166,7 @@ class TaskManagerImpl :
// running.
bool is_running_;
+ base::WeakPtrFactory<TaskManagerImpl> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(TaskManagerImpl);
};
« no previous file with comments | « no previous file | chrome/browser/task_manager/sampling/task_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698