Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private.cc

Issue 2827323002: gpu:: Remove GpuDataManagerObserver::OnVideoMemoryUsageStatsUpdate(). (Closed)
Patch Set: comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/gpu_data_manager_impl_private.cc
diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc
index 4dbdce147a73858c80b831e19bcdacbad2de20d4..647cf308b2074e107fd3c7b3e8a05331cf8d9580 100644
--- a/content/browser/gpu/gpu_data_manager_impl_private.cc
+++ b/content/browser/gpu/gpu_data_manager_impl_private.cc
@@ -264,15 +264,13 @@ bool ShouldDisableHardwareAcceleration() {
switches::kDisableGpu);
}
-void OnVideoMemoryUsageStats(const gpu::VideoMemoryUsageStats& stats) {
- GpuDataManagerImpl::GetInstance()->UpdateVideoMemoryUsageStats(stats);
-}
-
-void RequestVideoMemoryUsageStats(GpuProcessHost* host) {
+void RequestVideoMemoryUsageStats(
+ const base::Callback<void(const gpu::VideoMemoryUsageStats& stats)>&
+ callback,
+ GpuProcessHost* host) {
if (!host)
return;
- host->gpu_service()->GetVideoMemoryUsageStats(
- base::Bind(&OnVideoMemoryUsageStats));
+ host->gpu_service()->GetVideoMemoryUsageStats(callback);
}
void UpdateGpuInfoOnIO(const gpu::GPUInfo& gpu_info) {
@@ -450,10 +448,12 @@ bool GpuDataManagerImplPrivate::IsCompleteGpuInfoAvailable() const {
return IsEssentialGpuInfoAvailable();
}
-void GpuDataManagerImplPrivate::RequestVideoMemoryUsageStatsUpdate() const {
+void GpuDataManagerImplPrivate::RequestVideoMemoryUsageStatsUpdate(
+ const base::Callback<void(const gpu::VideoMemoryUsageStats& stats)>&
+ callback) const {
GpuProcessHost::CallOnIO(GpuProcessHost::GPU_PROCESS_KIND_SANDBOXED,
false /* force_create */,
- base::Bind(&RequestVideoMemoryUsageStats));
+ base::Bind(&RequestVideoMemoryUsageStats, callback));
}
bool GpuDataManagerImplPrivate::ShouldUseSwiftShader() const {
@@ -713,14 +713,6 @@ void GpuDataManagerImplPrivate::UpdateGpuFeatureInfo(
}
}
-void GpuDataManagerImplPrivate::UpdateVideoMemoryUsageStats(
- const gpu::VideoMemoryUsageStats& video_memory_usage_stats) {
- GpuDataManagerImpl::UnlockedSession session(owner_);
- observer_list_->Notify(FROM_HERE,
- &GpuDataManagerObserver::OnVideoMemoryUsageStatsUpdate,
- video_memory_usage_stats);
-}
-
void GpuDataManagerImplPrivate::AppendRendererCommandLine(
base::CommandLine* command_line) const {
DCHECK(command_line);

Powered by Google App Engine
This is Rietveld 408576698