Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ios/chrome/browser/ui/settings/settings_egtest.mm

Issue 2827313002: Replace drainUntilIdle with a dispatch_barrier_sync for Breakpad tests (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/test/app/chrome_test_util.h » ('j') | ios/chrome/test/app/chrome_test_util.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/settings/settings_egtest.mm
diff --git a/ios/chrome/browser/ui/settings/settings_egtest.mm b/ios/chrome/browser/ui/settings/settings_egtest.mm
index 00436051bc1601b0fc9f77a99252a39b5ba3d150..cdab355450c6cc485a42af301fd31d888e96fed9 100644
--- a/ios/chrome/browser/ui/settings/settings_egtest.mm
+++ b/ios/chrome/browser/ui/settings/settings_egtest.mm
@@ -470,7 +470,7 @@ bool IsCertificateCleared() {
wifiOnly);
// Breakpad uses dispatch_async to update its state. Wait to get to a
// consistent state.
- [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
+ chrome_test_util::WaitForBreakpadQueue();
}
// Checks for a given service that it is both recording and uploading, where
@@ -595,12 +595,12 @@ bool IsCertificateCleared() {
// Set the network to use a cellular network, which should disable uploading
// when the wifi-only flag is set.
chrome_test_util::SetWWANStateTo(YES);
- [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
+ chrome_test_util::WaitForBreakpadQueue();
[self assertMetricsServiceEnabledButNotUploading:serviceType];
// Turn off cellular network usage, which should enable uploading.
chrome_test_util::SetWWANStateTo(NO);
- [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
+ chrome_test_util::WaitForBreakpadQueue();
[self assertMetricsServiceEnabled:serviceType];
// kMetricsReportingEnabled ON and kMetricsReportingWifiOnly OFF
« no previous file with comments | « no previous file | ios/chrome/test/app/chrome_test_util.h » ('j') | ios/chrome/test/app/chrome_test_util.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698