chrome/common/extensions/api/webview_request.json - Issue 28273006: <webview>: Implement declarativeWebRequest API

Side by Side Diff: chrome/common/extensions/api/webview_request.json

Issue 28273006: <webview>: Implement declarativeWebRequest API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/web_request/web_request_api.cc ('K') | « chrome/common/extensions/api/extension_api.cc ('k') | chrome/common/extensions_api_resources.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 {

	7 "namespace": "webViewRequest",

	8 "description": "Use the <code>chrome.webViewRequest</code> API to intercept, block, or modify requests in-flight. It is significantly faster than the <a hre f='webRequest.html'><code>chrome.webRequest</code> API</a> because you can regis ter rules that are evaluated in the browser rather than the JavaScript engine wi th reduces roundtrip latencies and allows higher efficiency."
	vabr (Chromium) 2013/10/25 20:40:24 Maybe we should be careful with saying "significan Maybe we should be careful with saying "significantly faster", unless we have benchmarks to prove it. While speed was one of the main motivations for introducing DWR, and it saves the round-trips, the difference might not be that significant after all, due to recent improvements in V8 and other parts of Chrome critical for WebRequest. There is still a good incentive to use DWR as opposed to the old WR: declarative programming in general is a good practice to avoid boilerplate in the extensions, content scripts, and improve security. The security win is prominent outside of webview, where certain more dangerous parts of DWR (redirecting as opposed to just blocking) can be separated by higher permissions. This is probably not so relevant for webview. Fady Samuel 2013/10/25 22:48:08 The original WebRequest requires more lines of cod Show quoted text On 2013/10/25 20:40:24, vabr (Chromium) wrote: > Maybe we should be careful with saying "significantly faster", unless we have > benchmarks to prove it. While speed was one of the main motivations for > introducing DWR, and it saves the round-trips, the difference might not be that > significant after all, due to recent improvements in V8 and other parts of > Chrome critical for WebRequest. > > There is still a good incentive to use DWR as opposed to the old WR: declarative > programming in general is a good practice to avoid boilerplate in the > extensions, content scripts, and improve security. The security win is prominent > outside of webview, where certain more dangerous parts of DWR (redirecting as > opposed to just blocking) can be separated by higher permissions. This is > probably not so relevant for webview. The original WebRequest requires more lines of code. The declarative WebRequest API is more succinct in some cases I feel. The WebRequest API is used extensively in <webview> and so the declarative WebRequest was requested. I will soften the language to say it is potentially faster. vabr (Chromium) 2013/10/28 14:46:09 Thanks, "potentially" sounds safer. Show quoted text On 2013/10/25 22:48:08, Fady Samuel wrote: > On 2013/10/25 20:40:24, vabr (Chromium) wrote: > > Maybe we should be careful with saying "significantly faster", unless we have > > benchmarks to prove it. While speed was one of the main motivations for > > introducing DWR, and it saves the round-trips, the difference might not be > that > > significant after all, due to recent improvements in V8 and other parts of > > Chrome critical for WebRequest. > > > > There is still a good incentive to use DWR as opposed to the old WR: > declarative > > programming in general is a good practice to avoid boilerplate in the > > extensions, content scripts, and improve security. The security win is > prominent > > outside of webview, where certain more dangerous parts of DWR (redirecting as > > opposed to just blocking) can be separated by higher permissions. This is > > probably not so relevant for webview. > > The original WebRequest requires more lines of code. The declarative WebRequest > API is more succinct in some cases I feel. The WebRequest API is used > extensively in <webview> and so the declarative WebRequest was requested. I will > soften the language to say it is potentially faster. Thanks, "potentially" sounds safer.
	9 }

	10 ]

OLD	NEW