chrome/common/extensions/api/webview_request.json - Issue 28273006: <webview>: Implement declarativeWebRequest API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/api/webview_request.json

Issue 28273006: <webview>: Implement declarativeWebRequest API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed browser_tests build Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/api/events.json ('K') | « chrome/common/extensions/api/events.json ('k') | chrome/common/extensions_api_resources.grd » ('j') | chrome/renderer/resources/extensions/event.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 {

	7 "namespace": "webViewRequest",

	8 "description": "Use the <code>chrome.webViewRequest</code> API to intercept, block, or modify requests in-flight. It is potentially faster than the <a href= 'webRequest.html'><code>chrome.webRequest</code> API</a> because you can registe r rules that are evaluated in the browser rather than the JavaScript engine with reduces roundtrip latencies and allows higher efficiency."
	Jeffrey Yasskin 2013/11/09 02:47:22 Does webRequest exist on <webview> objects? It see Does webRequest exist on <webview> objects? It seems like the difference between webRequest and webViewRequest is subtle. Why not have "declarative" on webViewRequest? Fady Samuel 2013/11/10 03:39:56 This description is slightly incorrect. The condit Show quoted text On 2013/11/09 02:47:22, Jeffrey Yasskin wrote: > Does webRequest exist on <webview> objects? It seems like the difference between > webRequest and webViewRequest is subtle. Why not have "declarative" on > webViewRequest? This description is slightly incorrect. The condition/action objects exist on chrome.webViewRequest because they're independent of any particular webview, but the rules based events are on <webview>.request.. I'm not sure how to describe this well here. This API probably needs to go through API review. Jeffrey Yasskin* 2013/11/11 05:37:36 Mhmm. Let's do that before this API launches, but Show quoted text On 2013/11/10 03:39:56, Fady Samuel wrote: > On 2013/11/09 02:47:22, Jeffrey Yasskin wrote: > > Does webRequest exist on <webview> objects? It seems like the difference > between > > webRequest and webViewRequest is subtle. Why not have "declarative" on > > webViewRequest? > > This description is slightly incorrect. The condition/action objects exist on > chrome.webViewRequest because they're independent of any particular webview, but > the rules based events are on <webview>.request.*. I'm not sure how to describe > this well here. This API probably needs to go through API review. Mhmm. Let's do that before this API launches, but after this CL goes in (unless this CL would launch the new APIs, which I don't think it will). We can try to help word the docs better at that point.
	9 }

	10 ]

OLD	NEW