<webview>: Implement declarativeWebRequest API

chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative/rules_registry.h"
 
 // Here we test the TestRulesRegistry which is the simplest possible
 // implementation of RulesRegistryWithCache as a proxy for
 // RulesRegistryWithCache.
 
@@ skipping 196 matching lines @@
   // Prime registry.
   EXPECT_EQ("", AddRule(kExtensionId, kRuleId));
   EXPECT_EQ("", AddRule(kExtension2Id, kRuleId));
 
   // Check that the correct rules are removed.
   registry_->OnExtensionUnloaded(kExtensionId);
   EXPECT_EQ(0, GetNumberOfRules(kExtensionId));
   EXPECT_EQ(1, GetNumberOfRules(kExtension2Id));
 }
 
 TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {

[Jeffrey Yasskin, 2013/11/09 02:47:22]

We should also have a test that for webview registries, the rules are *not*
stored.

[Fady Samuel, 2013/11/10 03:39:56]

This is enforced by the RulesRegistryService. I added a test in the
RulesRegistryService unit tests.

   TestingProfile profile;
   // TestingProfile::Init makes sure that the factory method for a corresponding
   // extension system creates a TestExtensionSystem.
   extensions::TestExtensionSystem* system =
       static_cast<extensions::TestExtensionSystem*>(
           extensions::ExtensionSystem::Get(&profile));
   ExtensionPrefs* extension_prefs = system->CreateExtensionPrefs(
       CommandLine::ForCurrentProcess(), base::FilePath());
   system->CreateExtensionService(
       CommandLine::ForCurrentProcess(), base::FilePath(), false);
   // The value store is first created during CreateExtensionService.
   TestingValueStore* store = system->value_store();
 
   const std::string event_name("testEvent");
+  const RulesRegistry::WebViewKey key(0, 0);
   const std::string rules_stored_key(
       RulesCacheDelegate::GetRulesStoredKey(
           event_name, profile.IsOffTheRecord()));
   scoped_ptr<RulesCacheDelegate> cache_delegate(new RulesCacheDelegate(false));
   scoped_refptr<RulesRegistry> registry(new TestRulesRegistry(
-      &profile, event_name, content::BrowserThread::UI, cache_delegate.get()));
+      &profile, event_name, content::BrowserThread::UI,
+      cache_delegate.get()));
 
   // 1. Test the handling of preferences.
   // Default value is always true.
   EXPECT_TRUE(cache_delegate->GetDeclarativeRulesStored(kExtensionId));
 
   extension_prefs->UpdateExtensionPref(
       kExtensionId, rules_stored_key, new base::FundamentalValue(false));
   EXPECT_FALSE(cache_delegate->GetDeclarativeRulesStored(kExtensionId));
 
   extension_prefs->UpdateExtensionPref(
@@ skipping 46 matching lines @@
   // TestingProfile::Init makes sure that the factory method for a corresponding
   // extension system creates a TestExtensionSystem.
   extensions::TestExtensionSystem* system =
       static_cast<extensions::TestExtensionSystem*>(
           extensions::ExtensionSystem::Get(&profile));
   ExtensionPrefs* extension_prefs = system->CreateExtensionPrefs(
       CommandLine::ForCurrentProcess(), base::FilePath());
 
   const std::string event_name1("testEvent1");
   const std::string event_name2("testEvent2");
+  const RulesRegistry::WebViewKey key(0, 0);
   const std::string rules_stored_key1(
       RulesCacheDelegate::GetRulesStoredKey(
           event_name1, profile.IsOffTheRecord()));
   const std::string rules_stored_key2(
       RulesCacheDelegate::GetRulesStoredKey(
           event_name2, profile.IsOffTheRecord()));
   scoped_ptr<RulesCacheDelegate> cache_delegate1(new RulesCacheDelegate(false));
   scoped_refptr<RulesRegistry> registry1(new TestRulesRegistry(
       &profile, event_name1, content::BrowserThread::UI,
       cache_delegate1.get()));
@@ skipping 41 matching lines @@
   // 2. First run, adding a rule for the extension.
   scoped_ptr<RulesCacheDelegate> cache_delegate(new RulesCacheDelegate(false));
   scoped_refptr<TestRulesRegistry> registry(new TestRulesRegistry(
       &profile, "testEvent", content::BrowserThread::UI, cache_delegate.get()));
 
   AddRule(kExtensionId, kRuleId, registry.get());
   message_loop_.RunUntilIdle();  // Posted tasks store the added rule.
   EXPECT_EQ(1, GetNumberOfRules(kExtensionId, registry.get()));
 
   // 3. Restart the TestRulesRegistry and see the rule still there.
-  cache_delegate.reset(
-      new RulesCacheDelegate(false));
+  cache_delegate.reset(new RulesCacheDelegate(false));
   registry = new TestRulesRegistry(
       &profile, "testEvent", content::BrowserThread::UI, cache_delegate.get());
 
   message_loop_.RunUntilIdle();  // Posted tasks retrieve the stored rule.
   EXPECT_EQ(1, GetNumberOfRules(kExtensionId, registry.get()));
 }
 
 }  //  namespace extensions