Implement subtype relation for kernel based elements.

Implement subtype relation for kernel based elements.

+ check BackendUsage equivalence

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/0390e9f0af37ef0ab14f0c925f0657493b48dc2d

[Johnni Winther, 2017-04-20 13:12:13]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-04-20 13:18:51]

Description was changed from

==========
Implement subtype relation in for kernel based elements.
==========

to

==========
Implement subtype relation for kernel based elements.

+ check BackendUsage equivalence
==========

[Johnni Winther, 2017-04-20 13:27:40]

https://codereview.chromium.org/2827283002/diff/20001/pkg/compiler/lib/src/en...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2827283002/diff/20001/pkg/compiler/lib/src/en...
pkg/compiler/lib/src/enqueue.dart:282: impactSource: 'get of static function');
These are added to help debugging. We current only use the value if it is a
MemberElement.

[Siggi Cherem (dart-lang), 2017-04-21 16:41:14]

lgtm

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/types.dart (right):

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/types.dart:32: class _KernelDartTypes implements
DartTypes {
nits:
 - move this to the top - it's likely the first thing we want to see.
 - dartdoc :)

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/types.dart:77: return null;
throw instead?

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/world_builder.dart (right):

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:685: OrderedTypeSet
orderedTypeSet;
Do we gain much from tracking supertype separately? Maybe performance for
looking up the super-type? (I'm assuming the supertype is also stored in this
ordered set, correct?)

https://codereview.chromium.org/2827283002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/closed_world_test.dart (right):

https://codereview.chromium.org/2827283002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/closed_world_test.dart:195: print('$element');
delete?

[Johnni Winther, 2017-04-24 08:25:42]

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/types.dart (right):

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/types.dart:32: class _KernelDartTypes implements
DartTypes {
On 2017/04/21 16:41:13, Siggi Cherem (dart-lang) wrote:
> nits:
>  - move this to the top - it's likely the first thing we want to see.
>  - dartdoc :)

Done.

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/types.dart:77: return null;
On 2017/04/21 16:41:14, Siggi Cherem (dart-lang) wrote:
> throw instead?

We need this to pass for the closed world test.

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/world_builder.dart (right):

https://codereview.chromium.org/2827283002/diff/40001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:685: OrderedTypeSet
orderedTypeSet;
On 2017/04/21 16:41:14, Siggi Cherem (dart-lang) wrote:
> Do we gain much from tracking supertype separately? Maybe performance for
> looking up the super-type? (I'm assuming the supertype is also stored in this
> ordered set, correct?) 

It is, but we cannot distinguish it from the other supertypes.

https://codereview.chromium.org/2827283002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/closed_world_test.dart (right):

https://codereview.chromium.org/2827283002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/closed_world_test.dart:195: print('$element');
On 2017/04/21 16:41:14, Siggi Cherem (dart-lang) wrote:
> delete?

Done.

[Johnni Winther, 2017-04-24 08:53:11]

Description was changed from

==========
Implement subtype relation for kernel based elements.

+ check BackendUsage equivalence
==========

to

==========
Implement subtype relation for kernel based elements.

+ check BackendUsage equivalence

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0390e9f0af37ef0ab14f0c925f0657493b48dc2d
==========

[Johnni Winther, 2017-04-24 08:53:12]

Committed patchset #4 (id:60001) manually as
0390e9f0af37ef0ab14f0c925f0657493b48dc2d (presubmit successful).