Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 2827263006: Revert "Refactor ContentViewClient (6/6)" (Closed)
Patch Set: Revert "Let ImeAdapterAndroid have the same lifecycle as its Java peer" Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/ime_adapter_android.cc
diff --git a/content/browser/android/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc
similarity index 71%
rename from content/browser/android/ime_adapter_android.cc
rename to content/browser/renderer_host/ime_adapter_android.cc
index 695e53727c802388abe4594840a74010db712c56..b63f0652c70e6a717e26c8a6d44fe7c7d491ad48 100644
--- a/content/browser/android/ime_adapter_android.cc
+++ b/content/browser/renderer_host/ime_adapter_android.cc
@@ -1,11 +1,11 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/browser/android/ime_adapter_android.h"
+#include "content/browser/renderer_host/ime_adapter_android.h"
-#include <android/input.h>
#include <algorithm>
+#include <android/input.h>
#include <vector>
#include "base/android/jni_android.h"
@@ -14,12 +14,10 @@
#include "base/android/scoped_java_ref.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
-#include "content/browser/frame_host/interstitial_page_impl.h"
#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/renderer_host/render_view_host_delegate.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_android.h"
-#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/input_messages.h"
#include "content/common/view_messages.h"
#include "content/public/browser/browser_thread.h"
@@ -32,9 +30,7 @@
using base::android::AttachCurrentThread;
using base::android::ConvertJavaStringToUTF16;
-using base::android::ConvertUTF8ToJavaString;
using base::android::JavaParamRef;
-using base::android::ScopedJavaLocalRef;
namespace content {
namespace {
@@ -67,15 +63,6 @@ bool RegisterImeAdapter(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-jlong Init(JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- const JavaParamRef<jobject>& jweb_contents) {
- WebContents* web_contents = WebContents::FromJavaWebContents(jweb_contents);
- DCHECK(web_contents);
- return reinterpret_cast<intptr_t>(
- new ImeAdapterAndroid(env, obj, web_contents));
-}
-
// Callback from Java to convert BackgroundColorSpan data to a
// blink::WebCompositionUnderline instance, and append it to |underlines_ptr|.
void AppendBackgroundColorSpan(JNIEnv*,
@@ -90,9 +77,12 @@ void AppendBackgroundColorSpan(JNIEnv*,
std::vector<blink::WebCompositionUnderline>* underlines =
reinterpret_cast<std::vector<blink::WebCompositionUnderline>*>(
underlines_ptr);
- underlines->push_back(blink::WebCompositionUnderline(
- static_cast<unsigned>(start), static_cast<unsigned>(end),
- SK_ColorTRANSPARENT, false, static_cast<unsigned>(background_color)));
+ underlines->push_back(
+ blink::WebCompositionUnderline(static_cast<unsigned>(start),
+ static_cast<unsigned>(end),
+ SK_ColorTRANSPARENT,
+ false,
+ static_cast<unsigned>(background_color)));
}
// Callback from Java to convert UnderlineSpan data to a
@@ -107,100 +97,24 @@ void AppendUnderlineSpan(JNIEnv*,
std::vector<blink::WebCompositionUnderline>* underlines =
reinterpret_cast<std::vector<blink::WebCompositionUnderline>*>(
underlines_ptr);
- underlines->push_back(blink::WebCompositionUnderline(
- static_cast<unsigned>(start), static_cast<unsigned>(end), SK_ColorBLACK,
- false, SK_ColorTRANSPARENT));
+ underlines->push_back(
+ blink::WebCompositionUnderline(static_cast<unsigned>(start),
+ static_cast<unsigned>(end),
+ SK_ColorBLACK,
+ false,
+ SK_ColorTRANSPARENT));
}
-ImeAdapterAndroid::ImeAdapterAndroid(JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- WebContents* web_contents)
- : WebContentsObserver(web_contents), rwhva_(nullptr) {
- java_ime_adapter_ = JavaObjectWeakGlobalRef(env, obj);
+ImeAdapterAndroid::ImeAdapterAndroid(RenderWidgetHostViewAndroid* rwhva)
+ : rwhva_(rwhva) {
+ DCHECK(rwhva_);
}
ImeAdapterAndroid::~ImeAdapterAndroid() {
JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
+ base::android::ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
if (!obj.is_null())
- Java_ImeAdapter_destroy(env, obj);
-
- UpdateRenderProcessConnection(nullptr);
-}
-
-RenderWidgetHostViewAndroid* ImeAdapterAndroid::GetRenderWidgetHostViewAndroid()
- const {
- RenderWidgetHostView* rwhv = web_contents()->GetRenderWidgetHostView();
- WebContentsImpl* web_contents_impl =
- static_cast<WebContentsImpl*>(web_contents());
- if (web_contents_impl->ShowingInterstitialPage()) {
- rwhv = web_contents_impl->GetInterstitialPage()
- ->GetMainFrame()
- ->GetRenderViewHost()
- ->GetWidget()
- ->GetView();
- }
- return static_cast<RenderWidgetHostViewAndroid*>(rwhv);
-}
-
-void ImeAdapterAndroid::RenderViewReady() {
- UpdateRenderProcessConnection(GetRenderWidgetHostViewAndroid());
-
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
- if (!obj.is_null())
- Java_ImeAdapter_onConnectedToRenderProcess(env, obj);
-}
-
-void ImeAdapterAndroid::RenderViewHostChanged(RenderViewHost* old_host,
- RenderViewHost* new_host) {
- if (new_host) {
- UpdateRenderProcessConnection(static_cast<RenderWidgetHostViewAndroid*>(
- new_host->GetWidget()->GetView()));
- } else {
- UpdateRenderProcessConnection(nullptr);
- }
-}
-
-void ImeAdapterAndroid::DidAttachInterstitialPage() {
- UpdateRenderProcessConnection(GetRenderWidgetHostViewAndroid());
-}
-
-void ImeAdapterAndroid::DidDetachInterstitialPage() {
- UpdateRenderProcessConnection(GetRenderWidgetHostViewAndroid());
-}
-
-void ImeAdapterAndroid::WebContentsDestroyed() {
- delete this;
-}
-
-void ImeAdapterAndroid::UpdateRenderProcessConnection(
- RenderWidgetHostViewAndroid* new_rwhva) {
- if (rwhva_.get() == new_rwhva)
- return;
- if (rwhva_)
- rwhva_->set_ime_adapter(nullptr);
- if (new_rwhva) {
- new_rwhva->set_ime_adapter(this);
- rwhva_ = new_rwhva->GetWeakPtrAndroid();
- } else {
- rwhva_.reset();
- }
-}
-
-void ImeAdapterAndroid::UpdateState(const TextInputState& state) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
- if (obj.is_null())
- return;
-
- ScopedJavaLocalRef<jstring> jstring_text =
- ConvertUTF8ToJavaString(env, state.value);
- Java_ImeAdapter_updateState(env, obj, static_cast<int>(state.type),
- state.flags, state.mode, state.show_ime_if_needed,
- jstring_text, state.selection_start,
- state.selection_end, state.composition_start,
- state.composition_end, state.reply_to_request);
+ Java_ImeAdapter_detach(env, obj);
}
bool ImeAdapterAndroid::SendKeyEvent(
@@ -214,8 +128,6 @@ bool ImeAdapterAndroid::SendKeyEvent(
int scan_code,
bool is_system_key,
int unicode_char) {
- if (!rwhva_)
- return false;
NativeWebKeyboardEvent event = NativeWebKeyboardEventFromKeyEvent(
env, original_key_event, type, modifiers, time_ms, key_code, scan_code,
is_system_key, unicode_char);
@@ -288,18 +200,25 @@ void ImeAdapterAndroid::FinishComposingText(JNIEnv* env,
rwhi->ImeFinishComposingText(true);
}
+void ImeAdapterAndroid::AttachImeAdapter(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& java_object) {
+ java_ime_adapter_ = JavaObjectWeakGlobalRef(env, java_object);
+}
+
void ImeAdapterAndroid::CancelComposition() {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
+ base::android::ScopedJavaLocalRef<jobject> obj =
+ java_ime_adapter_.get(AttachCurrentThread());
if (!obj.is_null())
- Java_ImeAdapter_cancelComposition(env, obj);
+ Java_ImeAdapter_cancelComposition(AttachCurrentThread(), obj);
}
void ImeAdapterAndroid::FocusedNodeChanged(bool is_editable_node) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
+ base::android::ScopedJavaLocalRef<jobject> obj =
+ java_ime_adapter_.get(AttachCurrentThread());
if (!obj.is_null()) {
- Java_ImeAdapter_focusedNodeChanged(env, obj, is_editable_node);
+ Java_ImeAdapter_focusedNodeChanged(AttachCurrentThread(), obj,
+ is_editable_node);
}
}
@@ -319,7 +238,7 @@ void ImeAdapterAndroid::SetEditableSelectionOffsets(
void ImeAdapterAndroid::SetCharacterBounds(
const std::vector<gfx::RectF>& character_bounds) {
JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
+ base::android::ScopedJavaLocalRef<jobject> obj = java_ime_adapter_.get(env);
if (obj.is_null())
return;
@@ -334,9 +253,8 @@ void ImeAdapterAndroid::SetCharacterBounds(
coordinates_array[coordinates_array_index + 3] = rect.bottom();
}
Java_ImeAdapter_setCharacterBounds(
- env, obj,
- base::android::ToJavaFloatArray(env, coordinates_array.get(),
- coordinates_array_size));
+ env, obj, base::android::ToJavaFloatArray(env, coordinates_array.get(),
+ coordinates_array_size));
}
void ImeAdapterAndroid::SetComposingRegion(JNIEnv*,
@@ -398,9 +316,14 @@ void ImeAdapterAndroid::RequestCursorUpdate(
rwhi->GetRoutingID(), immediate_request, monitor_request));
}
+void ImeAdapterAndroid::ResetImeAdapter(JNIEnv* env,
+ const JavaParamRef<jobject>&) {
+ java_ime_adapter_.reset();
+}
+
RenderWidgetHostImpl* ImeAdapterAndroid::GetFocusedWidget() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- return rwhva_ ? rwhva_->GetFocusedWidget() : nullptr;
+ return rwhva_->GetFocusedWidget();
}
RenderFrameHost* ImeAdapterAndroid::GetFocusedFrame() {
@@ -408,8 +331,6 @@ RenderFrameHost* ImeAdapterAndroid::GetFocusedFrame() {
// We get the focused frame from the WebContents of the page. Although
// |rwhva_->GetFocusedWidget()| does a similar thing, there is no direct way
// to get a RenderFrameHost from its RWH.
- if (!rwhva_)
- return nullptr;
RenderWidgetHostImpl* rwh =
RenderWidgetHostImpl::From(rwhva_->GetRenderWidgetHost());
if (!rwh || !rwh->delegate())
« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698