Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2827263003: [ObjC ARC] Converts ios/chrome/browser/ui/promos:promos to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/promos:promos to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2827263003 Cr-Commit-Position: refs/heads/master@{#465995} Committed: https://chromium.googlesource.com/chromium/src/+/4e55a9eeab3362f2c90b63df1ecc74a3c2059ff3

Patch Set 1 #

Patch Set 2 : Fix autorelease #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ios/chrome/browser/ui/promos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/promos/signin_promo_view_controller.mm View 1 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-20 12:51:39 UTC) #6
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-20 14:01:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827263003/20001
3 years, 8 months ago (2017-04-20 14:03:23 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 14:06:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e55a9eeab3362f2c90b63df1ecc...

Powered by Google App Engine
This is Rietveld 408576698