README.md - Issue 2827083002: Created a new synchronous http client using RawSynchronousSockets.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: README.md

Issue 2827083002: Created a new synchronous http client using RawSynchronousSockets. (Closed)

Patch Set: Added more documentation, updated README Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 TODO: add README	1 Dart Synchronous HTTP Client

	2 ============================

	3

	4 A simple Dart HTTP client implemented using RawSynchronousSockets to allow for

	5 synchronous HTTP requests.
	zra 2017/04/20 15:41:40 We should have a warning here similar to the one o We should have a warning here similar to the one on RawSynchronousSocket. Basically, only use this for connections to localhost, and prefer using dart:io's HttpClient or package:http. I think the markdown format allows linking to stuff, so you should link to RawSynchronousSocket, dart:io's HttpClient and package:http. bkonyi 2017/04/20 18:07:56 Updated. I can't link to RawSynchronousSocket's AP Show quoted text On 2017/04/20 15:41:40, zra wrote: > We should have a warning here similar to the one on RawSynchronousSocket. > Basically, only use this for connections to localhost, and prefer using > dart:io's HttpClient or package:http. > > I think the markdown format allows linking to stuff, so you should link to > RawSynchronousSocket, dart:io's HttpClient and package:http. Updated. I can't link to RawSynchronousSocket's API page yet since it doesn't exist. Should I just link to the sync_socket.dart file on Github?
OLD	NEW

« no previous file with comments | « LICENSE ('k') | codereview.settings » ('j') | test/http_basic_test.dart » ('J')