Issue 2827008: [Isolates] Make instance variables of Heap non-static.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2827008: [Isolates] Make instance variables of Heap non-static. (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko, Dmitry Titov

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

[Isolates] Make instance variables of Heap non-static. Committed: http://code.google.com/p/v8/source/detail?r=4881

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -116 lines)			Patch
M	src/factory.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/heap.h	View	1	7 chunks	+38 lines, -38 lines	0 comments	Download
M	src/heap.cc	View	1	1 chunk	+52 lines, -75 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 6 months ago (2010-06-16 12:39:37 UTC) #2

LGTM.

http://codereview.chromium.org/2827008/diff/1/3
File src/heap.cc (right):

http://codereview.chromium.org/2827008/diff/1/3#newcode126
src/heap.cc:126: memset(roots_, 0, sizeof(Object*) * kRootListLength);
sizeof(roots_[0]) is more future-proof.

Expand Messages | Collapse Messages