Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses. (Closed)
Patch Set: Remove UNREACHED Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1883 matching lines...) Expand 10 before | Expand all | Expand 10 after
1894 if (!frame->GetSettings()->GetViewportEnabled()) 1894 if (!frame->GetSettings()->GetViewportEnabled())
1895 return false; 1895 return false;
1896 1896
1897 const TopDocumentRootScrollerController& controller = 1897 const TopDocumentRootScrollerController& controller =
1898 GetLayoutBox()->GetDocument().GetPage()->GlobalRootScrollerController(); 1898 GetLayoutBox()->GetDocument().GetPage()->GlobalRootScrollerController();
1899 1899
1900 return RootScrollerUtil::ScrollableAreaForRootScroller( 1900 return RootScrollerUtil::ScrollableAreaForRootScroller(
1901 controller.GlobalRootScroller()) == this; 1901 controller.GlobalRootScroller()) == this;
1902 } 1902 }
1903 1903
1904 FrameViewBase* PaintLayerScrollableArea::GetFrameViewBase() { 1904 bool PaintLayerScrollableArea::ScheduleAnimation() {
1905 return Box().GetFrame()->View(); 1905 return Box().GetFrame()->ScheduleAnimation(GetHostWindow());
1906 } 1906 }
1907 1907
1908 void PaintLayerScrollableArea::ResetRebuildScrollbarLayerFlags() { 1908 void PaintLayerScrollableArea::ResetRebuildScrollbarLayerFlags() {
1909 rebuild_horizontal_scrollbar_layer_ = false; 1909 rebuild_horizontal_scrollbar_layer_ = false;
1910 rebuild_vertical_scrollbar_layer_ = false; 1910 rebuild_vertical_scrollbar_layer_ = false;
1911 } 1911 }
1912 1912
1913 CompositorAnimationHost* PaintLayerScrollableArea::GetCompositorAnimationHost() 1913 CompositorAnimationHost* PaintLayerScrollableArea::GetCompositorAnimationHost()
1914 const { 1914 const {
1915 return layer_.GetLayoutObject().GetFrameView()->GetCompositorAnimationHost(); 1915 return layer_.GetLayoutObject().GetFrameView()->GetCompositorAnimationHost();
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
2133 2133
2134 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2134 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2135 ClampScrollableAreas() { 2135 ClampScrollableAreas() {
2136 for (auto& scrollable_area : *needs_clamp_) 2136 for (auto& scrollable_area : *needs_clamp_)
2137 scrollable_area->ClampScrollOffsetAfterOverflowChange(); 2137 scrollable_area->ClampScrollOffsetAfterOverflowChange();
2138 delete needs_clamp_; 2138 delete needs_clamp_;
2139 needs_clamp_ = nullptr; 2139 needs_clamp_ = nullptr;
2140 } 2140 }
2141 2141
2142 } // namespace blink 2142 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698