Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses.

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2729 matching lines @@
 void FrameView::ScrollbarStyleChanged() {
   // FIXME: Why does this only apply to the main frame?
   if (!frame_->IsMainFrame())
     return;
   AdjustScrollbarOpacity();
   ContentsResized();
   UpdateScrollbars();
   PositionScrollbarLayers();
 }
 
+bool FrameView::ScheduleAnimation() {

[haraken, 2017/04/19 09:44:07]

It seems like we have too many proxy methods to call ScheduleAnimation. Can we
try to remove FrameView::ScheduleAnimation and Frame::ScheduleAnimation?

The caller sites can directly call HostWindow::ScheduleAnimation.

(Not related to this CL, HostWindow should be renamed to PlatformChromeClient.
It's never related to a window.)

[joelhockey, 2017/04/19 10:27:54]

2 CLs on the wey soon for this.

+  return frame_->ScheduleAnimation(GetHostWindow());
+}
+
 void FrameView::NotifyPageThatContentAreaWillPaint() const {
   Page* page = frame_->GetPage();
   if (!page)
     return;
 
   ContentAreaWillPaint();
 
   if (!scrollable_areas_)
     return;
 
@@ skipping 1810 matching lines @@
                            ? horizontal_scrollbar_mode_
                            : vertical_scrollbar_mode_;
 
   return mode == kScrollbarAuto || mode == kScrollbarAlwaysOn;
 }
 
 bool FrameView::ShouldPlaceVerticalScrollbarOnLeft() const {
   return false;
 }
 
-FrameViewBase* FrameView::GetFrameViewBase() {
-  return this;
-}
-
 LayoutRect FrameView::ScrollIntoView(const LayoutRect& rect_in_content,
                                      const ScrollAlignment& align_x,
                                      const ScrollAlignment& align_y,
                                      ScrollType scroll_type) {
   LayoutRect view_rect(VisibleContentRect());
   LayoutRect expose_rect = ScrollAlignment::GetRectToExpose(
       view_rect, rect_in_content, align_x, align_y);
   if (expose_rect != view_rect) {
     SetScrollOffset(
         ScrollOffset(expose_rect.X().ToFloat(), expose_rect.Y().ToFloat()),
@@ skipping 752 matching lines @@
 void FrameView::SetAnimationHost(
     std::unique_ptr<CompositorAnimationHost> host) {
   animation_host_ = std::move(host);
 }
 
 LayoutUnit FrameView::CaretWidth() const {
   return LayoutUnit(GetHostWindow()->WindowToViewportScalar(1));
 }
 
 }  // namespace blink