Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: media/base/renderer_factory_selector.cc

Issue 2826883002: Rename AdaptiveRendererFactory (Closed)
Patch Set: Addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/renderer_factory_selector.h ('k') | media/base/renderer_factory_selector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/renderer_factory_selector.cc
diff --git a/media/base/renderer_factory_selector.cc b/media/base/renderer_factory_selector.cc
index 3eb41fced272095dd0f017d5f20e22767959930b..d1fc94bb4908ff9601037967822144ac9f4dfb58 100644
--- a/media/base/renderer_factory_selector.cc
+++ b/media/base/renderer_factory_selector.cc
@@ -23,38 +23,40 @@ void RendererFactorySelector::AddFactory(
void RendererFactorySelector::SetBaseFactoryType(FactoryType type) {
DCHECK(factories_[type]);
base_factory_type_ = type;
- current_factory_needs_update_ = true;
}
-// For the moment, this method should only be called once or twice.
-// This method will be regularly called whenever the logic in choosing a
-// renderer type is moved out of the AdaptiveRendererFactory, into this method.
-void RendererFactorySelector::UpdateCurrentFactory() {
+RendererFactory* RendererFactorySelector::GetCurrentFactory() {
+ // We cannot use the MEDIA_PLAYER and the COURIER factory at the same time.
+ DCHECK(!use_media_player_ || !query_is_remoting_active_cb_);
+
DCHECK(base_factory_type_);
FactoryType next_factory_type = base_factory_type_.value();
if (use_media_player_)
next_factory_type = FactoryType::MEDIA_PLAYER;
+ if (query_is_remoting_active_cb_ && query_is_remoting_active_cb_.Run())
+ next_factory_type = FactoryType::COURIER;
+
DVLOG(1) << __func__ << " Selecting factory type: " << next_factory_type;
- current_factory_ = factories_[next_factory_type].get();
- current_factory_needs_update_ = false;
-}
+ RendererFactory* current_factory = factories_[next_factory_type].get();
-RendererFactory* RendererFactorySelector::GetCurrentFactory() {
- if (current_factory_needs_update_)
- UpdateCurrentFactory();
+ DCHECK(current_factory);
- DCHECK(current_factory_);
- return current_factory_;
+ return current_factory;
}
#if defined(OS_ANDROID)
void RendererFactorySelector::SetUseMediaPlayer(bool use_media_player) {
use_media_player_ = use_media_player;
- current_factory_needs_update_ = true;
}
#endif
+void RendererFactorySelector::SetQueryIsRemotingActiveCB(
+ QueryIsRemotingActiveCB query_is_remoting_active_cb) {
+ DCHECK(!query_is_remoting_active_cb_);
+ query_is_remoting_active_cb_ = query_is_remoting_active_cb;
+}
+
} // namespace media
« no previous file with comments | « media/base/renderer_factory_selector.h ('k') | media/base/renderer_factory_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698