Rename AdaptiveRendererFactory

media/remoting/courier_renderer_factory.h

Index: media/remoting/courier_renderer_factory.h
diff --git a/media/remoting/adaptive_renderer_factory.h b/media/remoting/courier_renderer_factory.h
similarity index 54%
rename from media/remoting/adaptive_renderer_factory.h
rename to media/remoting/courier_renderer_factory.h
index b399238dc65d4680a86c37256d74c0e8fac7fb24..076f2c988f34027710f59d50de31dcecebeb9d5a 100644
--- a/media/remoting/adaptive_renderer_factory.h
+++ b/media/remoting/courier_renderer_factory.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef MEDIA_REMOTING_ADAPTIVE_RENDERER_FACTORY_H_
-#define MEDIA_REMOTING_ADAPTIVE_RENDERER_FACTORY_H_
+#ifndef MEDIA_REMOTING_COURIER_RENDERER_FACTORY_H_
+#define MEDIA_REMOTING_COURIER_RENDERER_FACTORY_H_
 
 #include "media/base/renderer_factory.h"
 #include "media/remoting/renderer_controller.h"
@@ -11,14 +11,11 @@
 namespace media {
 namespace remoting {
 
-// Creates Renderers for either local playback or remote playback, as directed
-// by the RendererController.
-class AdaptiveRendererFactory : public RendererFactory {
+// Creates Renderers for remote playback.
+class CourierRendererFactory : public RendererFactory {
  public:
-  AdaptiveRendererFactory(
-      std::unique_ptr<RendererFactory> default_renderer_factory,
-      std::unique_ptr<RendererController> controller);
-  ~AdaptiveRendererFactory() override;
+  CourierRendererFactory(std::unique_ptr<RendererController> controller);

[miu, 2017/05/02 22:40:04]

Please add 'explicit' keyword for 1-arg ctor.

[tguilbert, 2017/05/03 01:34:25]

Done.

+  ~CourierRendererFactory() override;
 
   std::unique_ptr<Renderer> CreateRenderer(
       const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
@@ -27,14 +24,17 @@ class AdaptiveRendererFactory : public RendererFactory {
       VideoRendererSink* video_renderer_sink,
       const RequestSurfaceCB& request_surface_cb) override;
 
+  // Indicates whether or not we should emit a CourierRenderer, based off of

[miu, 2017/05/02 22:40:04]

nit: For those unfamiliar with the larger system, can we word this comment as
something like, "Called by RendererFactorySelector to determine when to create
CourierRenderers. CourierRenderers are created when activating media remoting."

[tguilbert, 2017/05/03 01:34:25]

I changed the method name to match the name of the CB in the RFS. I can also
change it to "HasRemotingStarted" if there is a difference between the "Active"
and "Started" remoting state, or if a distinction might appear in the future.

+  // what |controller_| tells us.
+  bool ShouldCreateCourierRenderer();
+
  private:
-  const std::unique_ptr<RendererFactory> default_renderer_factory_;
   const std::unique_ptr<RendererController> controller_;
 
-  DISALLOW_COPY_AND_ASSIGN(AdaptiveRendererFactory);
+  DISALLOW_COPY_AND_ASSIGN(CourierRendererFactory);
 };
 
 }  // namespace remoting
 }  // namespace media
 
-#endif  // MEDIA_REMOTING_ADAPTIVE_RENDERER_FACTORY_H_
+#endif  // MEDIA_REMOTING_COURIER_RENDERER_FACTORY_H_