Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2826793002: [Fuchsia] Build only the parts of the SDK that are needed (Closed)

Created:
3 years, 8 months ago by zra
Modified:
3 years, 8 months ago
Reviewers:
rmacnak, Cutch, P.Y.L.
CC:
reviews_dartlang.org, P.Y.L.
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Fuchsia] Build only the parts of the SDK that are needed In particular, dart2js, dartdoc, and ddc aren't used. R=johnmccutchan@google.com, pylaligand@google.com Committed: https://github.com/dart-lang/sdk/commit/b6bb2978e18475cb8833a76094ee8320f74ec032

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Fix deps and output path #

Patch Set 4 : Back out bad fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+471 lines, -110 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -72 lines 0 comments Download
A sdk/BUILD.gn View 1 2 3 1 chunk +345 lines, -0 lines 0 comments Download
A tools/copy_tree.py View 1 chunk +56 lines, -0 lines 0 comments Download
M tools/create_sdk.py View 1 4 chunks +2 lines, -38 lines 0 comments Download
A tools/write_revision_file.py View 1 chunk +34 lines, -0 lines 0 comments Download
A tools/write_version_file.py View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
3 years, 8 months ago (2017-04-18 21:15:08 UTC) #2
Cutch
lgtm
3 years, 8 months ago (2017-04-18 21:16:15 UTC) #3
P.Y.L.
lgtm
3 years, 8 months ago (2017-04-18 21:18:11 UTC) #5
zra
3 years, 8 months ago (2017-04-19 16:00:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b6bb2978e18475cb8833a76094ee8320f74ec032 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698