Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: ios/chrome/browser/payments/shipping_address_selection_coordinator.mm

Issue 2826713002: [Payment Request] Refactors the remaining selector view controllers (Closed)
Patch Set: Addressed comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/payments/shipping_address_selection_coordinator.mm
diff --git a/ios/chrome/browser/payments/shipping_address_selection_coordinator.mm b/ios/chrome/browser/payments/shipping_address_selection_coordinator.mm
index a2636daf710a3efa7926a7e5030aed1341bf5c65..b7291aa63713273b4628bcf73f12b8878945c728 100644
--- a/ios/chrome/browser/payments/shipping_address_selection_coordinator.mm
+++ b/ios/chrome/browser/payments/shipping_address_selection_coordinator.mm
@@ -20,6 +20,9 @@ namespace {
using ::payment_request_util::GetShippingAddressSelectorErrorMessage;
using ::payments::GetShippingAddressSectionString;
using ::payments::GetShippingAddressSelectorInfoMessage;
+
+// The delay in nano seconds before notifying the delegate of the selection.
+const int64_t kDelegateNotificationDelayInNanoSeconds = 0.2 * NSEC_PER_SEC;
} // namespace
@interface ShippingAddressSelectionCoordinator ()
@@ -116,12 +119,11 @@ using ::payments::GetShippingAddressSelectorInfoMessage;
self.viewController.view.userInteractionEnabled = NO;
__weak ShippingAddressSelectionCoordinator* weakSelf = self;
dispatch_after(
- dispatch_time(DISPATCH_TIME_NOW,
- static_cast<int64_t>(0.2 * NSEC_PER_SEC)),
+ dispatch_time(DISPATCH_TIME_NOW, kDelegateNotificationDelayInNanoSeconds),
dispatch_get_main_queue(), ^{
[weakSelf.mediator setState:PaymentRequestSelectorStatePending];
[weakSelf.viewController loadModel];
- [[weakSelf.viewController collectionView] reloadData];
+ [weakSelf.viewController.collectionView reloadData];
[weakSelf.delegate shippingAddressSelectionCoordinator:weakSelf
didSelectShippingAddress:shippingAddress];

Powered by Google App Engine
This is Rietveld 408576698