Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 28267: Fix 8200: Pressing Esc should cancel dialogs, not commit.... (Closed)

Created:
11 years, 9 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix 8200: Pressing Esc should cancel dialogs, not commit. When we create the OK & Cancel dialog buttons in DialogClientView, we were registering OK as a handler for Escape, even though the dialog had a Cancel button. This is because we register for Esc if the member variable |cancel_ button_| is NULL. Problem is, that member isn't created until later on in that function. We should be checking the |buttons| flags instead. TEST=Open the Clear Browsing Data dialog, press Tab twice, press Esc and make sure that the dialog closes and nothing is cleared (from whatever checkbox was selected). BUG=8200 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/views/dialog_client_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
11 years, 9 months ago (2009-02-27 20:59:16 UTC) #1
jcampan
11 years, 9 months ago (2009-02-27 21:02:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698