Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2826693004: Run formatter on the analyzer. (Closed)

Created:
3 years, 8 months ago by Jacob
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Run formatter on the analyzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/kernel/loader.dart View 5 chunks +10 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/utilities_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/tool/perf.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
https://codereview.chromium.org/2826693004/diff/1/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart File pkg/analyzer/lib/src/generated/testing/test_type_provider.dart (right): https://codereview.chromium.org/2826693004/diff/1/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart#newcode421 pkg/analyzer/lib/src/generated/testing/test_type_provider.dart:421: ..factory = true this file is in the generated ...
3 years, 8 months ago (2017-04-18 23:57:42 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2826693004/diff/1/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart File pkg/analyzer/lib/src/generated/testing/test_type_provider.dart (right): https://codereview.chromium.org/2826693004/diff/1/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart#newcode421 pkg/analyzer/lib/src/generated/testing/test_type_provider.dart:421: ..factory = true On 2017/04/18 23:57:42, Jacob wrote: ...
3 years, 8 months ago (2017-04-19 15:19:58 UTC) #3
Jacob
3 years, 8 months ago (2017-04-19 15:24:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6ac3a24a2eb25744fa0a02a495b3a4419ad90262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698