Remove JavaScriptBackend from ClosedWorldBase

pkg/compiler/lib/src/js_backend/backend.dart

Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 4b640d3963490fb01233035fa15c9a2ff6040a24..eb2f8a28dd9548783ca6211fefab7952d0440732 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -771,6 +771,11 @@ class JavaScriptBackend {
     validateInterceptorImplementsAllObjectMethods(commonElements.jsNullClass);
   }
 
+  void onResolutionEnd() {

[Siggi Cherem (dart-lang), 2017/04/18 15:58:05]

it seems a bit confusing to have two events called "End" and "Complete", looking
at the name it's not clear why they are different.

Since we are here, I actually want to move a way from the onEvent names. I
rather have names that describe what the method is doing. For example:

  onResolutionEnd => split into "buildUsage()" and "buildInterceptorData()"
  onResolutionComplete() => buildAnalysisData()

"Analysis" is a bit general, a better name would be nice :)

Thoughts?

[Johnni Winther, 2017/04/19 09:30:33]

The actually order in which these objects are created is still fluctuating (some
still get a Compiler object and do everything lazily). I'd rather wait until the
order has stabilized to refactor how and what we call these.

Change the name of [onResolutionComplete] to [onResolutionClosedWorld] and added
comments to [onResolutionStart], [onResolutionEnd] and [onResolutionClosedWorld]
to clarify when these are called.

+    _backendUsage = backendUsageBuilder.close();
+    _interceptorData = interceptorDataBuilder.onResolutionComplete();
+  }
+
   void onResolutionComplete(
       ClosedWorld closedWorld, ClosedWorldRefiner closedWorldRefiner) {
     for (MemberEntity entity
@@ -779,7 +784,6 @@ class JavaScriptBackend {
     }
     mirrorsDataBuilder.computeMembersNeededForReflection(
         compiler.enqueuer.resolution.worldBuilder, closedWorld);
-    _backendUsage = backendUsageBuilder.close();
     _rtiNeed = rtiNeedBuilder.computeRuntimeTypesNeed(
         compiler.enqueuer.resolution.worldBuilder,
         closedWorld,
@@ -787,7 +791,6 @@ class JavaScriptBackend {
         commonElements,
         _backendUsage,
         enableTypeAssertions: compiler.options.enableTypeAssertions);
-    _interceptorData = interceptorDataBuilder.onResolutionComplete(closedWorld);
     _oneShotInterceptorData =
         new OneShotInterceptorData(interceptorData, commonElements);
     mirrorsResolutionAnalysis.onResolutionComplete();