Remove JavaScriptBackend from ClosedWorldBase

Remove JavaScriptBackend from ClosedWorldBase

Also extract more extract more methods from ClosedWorldImpl into
ClosedWorldBase.

This is a step towards creating a closed world object from kernel based
elements. This CL adds the first mock of that object.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ee4b7761080b83bee0d340d767dd941cd3c26df9

Reverted:
https://github.com/dart-lang/sdk/commit/6c75646b3e3dded2622a0098210d1700af35461c

Committed: https://github.com/dart-lang/sdk/commit/39be6c2d72630c1397757b3bf240d6357021d801

[Johnni Winther, 2017-04-18 11:53:34]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-04-18 15:58:05]

https://codereview.chromium.org/2826673002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2826673002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:774: void onResolutionEnd() {
it seems a bit confusing to have two events called "End" and "Complete", looking
at the name it's not clear why they are different.

Since we are here, I actually want to move a way from the onEvent names. I
rather have names that describe what the method is doing. For example:

  onResolutionEnd => split into "buildUsage()" and "buildInterceptorData()"
  onResolutionComplete() => buildAnalysisData()

"Analysis" is a bit general, a better name would be nice :)

Thoughts?

[Siggi Cherem (dart-lang), 2017-04-18 15:58:10]

(otherwise lgtm)

[Johnni Winther, 2017-04-19 09:14:09]

Description was changed from

==========
Remove JavaScriptBackend from ClosedWorldBase

Also extract more extract more methods from ClosedWorldImpl into
ClosedWorldBase.

This is a step towards creating a closed world object from kernel based
elements. This CL adds the first mock of that object.
==========

to

==========
Remove JavaScriptBackend from ClosedWorldBase

Also extract more extract more methods from ClosedWorldImpl into
ClosedWorldBase.

This is a step towards creating a closed world object from kernel based
elements. This CL adds the first mock of that object.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ee4b7761080b83bee0d340d767dd941cd3c26df9
==========

[Johnni Winther, 2017-04-19 09:14:10]

Committed patchset #2 (id:20001) manually as
ee4b7761080b83bee0d340d767dd941cd3c26df9 (presubmit successful).

[Johnni Winther, 2017-04-19 09:30:33]

https://codereview.chromium.org/2826673002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2826673002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:774: void onResolutionEnd() {
On 2017/04/18 15:58:05, Siggi Cherem (dart-lang) wrote:
> it seems a bit confusing to have two events called "End" and "Complete",
looking
> at the name it's not clear why they are different.
> 
> Since we are here, I actually want to move a way from the onEvent names. I
> rather have names that describe what the method is doing. For example:
> 
>   onResolutionEnd => split into "buildUsage()" and "buildInterceptorData()"
>   onResolutionComplete() => buildAnalysisData()
> 
> "Analysis" is a bit general, a better name would be nice :)
> 
> Thoughts?

The actually order in which these objects are created is still fluctuating (some
still get a Compiler object and do everything lazily). I'd rather wait until the
order has stabilized to refactor how and what we call these.

Change the name of [onResolutionComplete] to [onResolutionClosedWorld] and added
comments to [onResolutionStart], [onResolutionEnd] and [onResolutionClosedWorld]
to clarify when these are called.

[sra1, 2017-04-19 19:33:17]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-04-19 19:33:18]

This CL causes a 10% regression on Intl.NumberFormat.format.oneshot

Old code:

          t4 = this._symbols.ZERO_DIGIT;
          if (t4.length === 0)
            H.throwExpression(H.IterableElementError_noElement());
          t2._contents +=
H.Primitives_stringFromCharCode(C.JSString_methods._codeUnitAt$1(t4, 0) + t3 -
t1);

New code:

          t4 = new H.CodeUnits(this._symbols.ZERO_DIGIT);
          t2._contents += H.Primitives_stringFromCharCode(t4.get$first(t4) + t3
- t1);


The old code inlined CodeUnits.first (which is ListMixin.first via inheritance
and mixins).
The new code does not.

The inlining decision in the ssa/builder.dart depends on identifying the type of
the receiver and finding a single matching method.


We will revert this change.

[Johnni Winther, 2017-04-20 11:32:18]

Description was changed from

==========
Remove JavaScriptBackend from ClosedWorldBase

Also extract more extract more methods from ClosedWorldImpl into
ClosedWorldBase.

This is a step towards creating a closed world object from kernel based
elements. This CL adds the first mock of that object.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ee4b7761080b83bee0d340d767dd941cd3c26df9
==========

to

==========
Remove JavaScriptBackend from ClosedWorldBase

Also extract more extract more methods from ClosedWorldImpl into
ClosedWorldBase.

This is a step towards creating a closed world object from kernel based
elements. This CL adds the first mock of that object.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ee4b7761080b83bee0d340d767dd941cd3c26df9

Reverted:
https://github.com/dart-lang/sdk/commit/6c75646b3e3dded2622a0098210d1700af35461c
==========

[Johnni Winther, 2017-04-20 11:38:25]

PTAL @ the last patch

[Siggi Cherem (dart-lang), 2017-04-20 22:43:58]

lgtm - (sorry, I honestly thought the code was just moving around and didn't pay
close attention to see if there were also semantic changes).

[Johnni Winther, 2017-04-24 06:45:19]

Description was changed from

==========
Remove JavaScriptBackend from ClosedWorldBase

Also extract more extract more methods from ClosedWorldImpl into
ClosedWorldBase.

This is a step towards creating a closed world object from kernel based
elements. This CL adds the first mock of that object.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ee4b7761080b83bee0d340d767dd941cd3c26df9

Reverted:
https://github.com/dart-lang/sdk/commit/6c75646b3e3dded2622a0098210d1700af35461c
==========

to

==========
Remove JavaScriptBackend from ClosedWorldBase

Also extract more extract more methods from ClosedWorldImpl into
ClosedWorldBase.

This is a step towards creating a closed world object from kernel based
elements. This CL adds the first mock of that object.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ee4b7761080b83bee0d340d767dd941cd3c26df9

Reverted:
https://github.com/dart-lang/sdk/commit/6c75646b3e3dded2622a0098210d1700af35461c

Committed:
https://github.com/dart-lang/sdk/commit/39be6c2d72630c1397757b3bf240d6357021d801
==========

[Johnni Winther, 2017-04-24 06:45:20]

Committed patchset #4 (id:60001) manually as
39be6c2d72630c1397757b3bf240d6357021d801 (presubmit successful).