Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)
Patch Set: Append Internal to all protected methods Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl
index 2a0bc8e5e521451da029f6877fd9152f260188a9..49c0f7f639655ffe2e5f559236133f1978337aa0 100644
--- a/third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl
@@ -1,16 +1,30 @@
-{% from 'fields/field.tmpl' import encode, decode, return_type %}
-{% macro decl_methods(field) -%}
-inline static {{return_type(field)}} {{field.initial_method_name}}() {
+{% from 'fields/field.tmpl' import encode, decode, getter_expression, setter_expression, return_type %}
+{% macro decl_public_methods(field) -%}
+inline static {{field.type_name}} {{field.initial_method_name}}() {
return {{field.default_value}};
}
{{return_type(field)}} {{field.getter_method_name}}() const {
+ return {{decode(field, getter_expression(field))}};
+}
+void {{field.setter_method_name}}(const {{field.type_name}}& v) {
+ {{setter_expression(field)}} = {{encode(field, "v")}};
+}
+inline void {{field.resetter_method_name}}() {
+ {{setter_expression(field)}} = {{encode(field, field.default_value)}};
+}
+{%- endmacro %}
+
+{% macro decl_protected_methods(field) -%}
+inline static {{field.type_name}} {{field.initial_method_name}}() {
+ return {{field.default_value}};
+}
+{{return_type(field)}} {{field.internal_getter_method_name}}() const {
return {{decode(field, field.name)}};
}
-void {{field.setter_method_name}}({{field.type_name}} v) {
+void {{field.internal_setter_method_name}}({{field.type_name}} v) {
{{field.name}} = {{encode(field, "v")}};
}
inline void {{field.resetter_method_name}}() {
{{field.name}} = {{encode(field, field.default_value)}};
}
{%- endmacro %}
-

Powered by Google App Engine
This is Rietveld 408576698