third_party/WebKit/Source/build/scripts/make_computed_style_base.py - Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)

Patch Set: Append Internal to all protected methods Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

index fbb0aff6366e0d9a2d3d65e2eb8eb658f45d8fde..bdc5f3e5d3c88ee6880a36b4ac4e4f8be4d32780 100755

--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

@@ -134,6 +134,9 @@ class Field(object):

# Method names

self.getter_method_name = getter_method_name

self.setter_method_name = setter_method_name

+ self.internal_getter_method_name = method_name(join_name(getter_method_name, name_for_methods, 'Internal'))

+ self.internal_mutable_method_name = method_name(join_name('Mutable', name_for_methods, 'Internal'))

+ self.internal_setter_method_name = method_name(join_name(setter_method_name, name_for_methods, 'Internal'))

self.initial_method_name = initial_method_name

self.resetter_method_name = method_name(join_name('Reset', name_for_methods))