Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)
Patch Set: Adds protected methods for all fields that need it Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl
index b5753c26a001eebabd14697eafbff861b33a901b..5e8cf15672dfaf1dd56cabdd69b5b5936582814e 100644
--- a/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl
@@ -1,8 +1,15 @@
+{% from 'fields/field.tmpl' import decode, encode, getter_expression, setter_expression, return_type %}
{% import 'fields/base.tmpl' as base %}
{% from 'fields/field.tmpl' import decode %}
-{% macro decl_methods(field) %}
-{{base.decl_methods(field)}}
+{% macro decl_public_methods(field) %}
+{{base.decl_public_methods(field)}}
void {{field.setter_method_name}}({{field.type_name}}&& v) {
{{field.name}} = std::move({{decode(field, "v")}});
}
{% endmacro %}
+
+{% macro decl_protected_methods(field) -%}
+{{field.type_name}}& {{field.mutable_method_name}}() {
+ return {{decode(field, getter_expression(field))}};
+}
+{%- endmacro %}

Powered by Google App Engine
This is Rietveld 408576698