third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl - Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)

Patch Set: Clean up nits prelanding Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/keyword.tmpl ('k') | third_party/WebKit/Source/build/scripts/templates/fields/primitive.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

index dfae1505d607526465d4d271b8dbf48b441e635f..afa64134a5f8fe3c48636f50f0486b0ff00059a9 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

@@ -1,5 +1,5 @@

-{% from 'fields/field.tmpl' import encode %}

-{% macro decl_methods(field) %}

+{% from 'fields/field.tmpl' import encode, argument_type %}

+{% macro decl_public_methods(field) %}

bool {{field.getter_method_name}}() const {

return {{field.name}};

}

@@ -7,3 +7,8 @@ void {{field.setter_method_name}}() {

{{field.name}} = {{encode(field, "true")}};

}

{% endmacro %}

+{% macro decl_protected_methods(field) -%}

+void {{field.internal_setter_method_name}}({{argument_type(field)}} v) {

+ {{field.name}} = {{encode(field, "v")}};

+{%- endmacro %}