third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl - Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)

Patch Set: Clean up nits prelanding Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl ('k') | third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

index b530be774738c6c88f23d94cc81d614c2b40797e..7cfd99671a4bddd9d5446441f3a42952be9cbdae 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

@@ -1,8 +1,14 @@

{% import 'fields/base.tmpl' as base %}

{% from 'fields/field.tmpl' import decode %}

-{% macro decl_methods(field) %}

-{{base.decl_methods(field)}}

+{% macro decl_public_methods(field) %}

+{{base.decl_public_methods(field)}}

void {{field.setter_method_name}}({{field.type_name}}&& v) {

{{field.name}} = std::move(v);

}

{% endmacro %}

+{% macro decl_protected_methods(field) -%}

+{{field.type_name}}& {{field.internal_mutable_method_name}}() {

+ return {{decode(field, field.name)}};

+{%- endmacro %}