third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl - Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)

Patch Set: Clean up nits prelanding Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

index 03a48012e77dde6c9d76d4582bd0b1692826e4ba..bbd444f08313a406cf7f2d8d000f3c8884636d13 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

@@ -81,7 +81,7 @@ class CORE_EXPORT ComputedStyleBase {

{% for field in fields %}

// {{field.property_name}}

- {{field_templates[field.field_template].decl_methods(field)|indent(2)}}

+ {{field_templates[field.field_template].decl_public_methods(field)|indent(2)}}

{% endfor %}

protected:

@@ -93,6 +93,14 @@ class CORE_EXPORT ComputedStyleBase {

{% endfor %}

{}

+ {% for field in fields %}

+ {% if field.field_template in ('storage_only', 'monotonic_flag', 'external') %}

+ // {{field.property_name}}

+ {{field_templates[field.field_template].decl_protected_methods(field)|indent(2)}}

+ {% endif %}

+ {% endfor %}

~ComputedStyleBase() = default;

// Storage.