Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)
Patch Set: Incorporating shend@'s suggestions Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% from 'fields/field.tmpl' import decode, encode, return_type %}
suzyh_UTC10 (ex-contributor) 2017/04/19 08:03:33 Your change only seems to introduce a usage of 'de
nainar 2017/04/19 08:49:35 Deleted this line.
1 {% import 'fields/base.tmpl' as base %} 2 {% import 'fields/base.tmpl' as base %}
2 {% from 'fields/field.tmpl' import decode %} 3 {% from 'fields/field.tmpl' import decode %}
3 {% macro decl_methods(field) %} 4 {% macro decl_public_methods(field) %}
4 {{base.decl_methods(field)}} 5 {{base.decl_public_methods(field)}}
5 void {{field.setter_method_name}}({{field.type_name}}&& v) { 6 void {{field.setter_method_name}}({{field.type_name}}&& v) {
6 {{field.name}} = std::move({{decode(field, "v")}}); 7 {{field.name}} = std::move({{decode(field, "v")}});
7 } 8 }
8 {% endmacro %} 9 {% endmacro %}
10
11 {% macro decl_protected_methods(field) -%}
12 {{field.type_name}}& {{field.internal_mutable_method_name}}() {
13 return {{decode(field, field.name)}};
14 }
15 {%- endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698