Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/storage_only.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)
Patch Set: Adds protected methods for all fields that need it Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% macro decl_methods(field) -%} 1 {% from 'fields/field.tmpl' import encode, decode, getter_expression, setter_exp ression, return_type %}
2 {% macro decl_public_methods(field) -%}
2 // Getters and setters not generated 3 // Getters and setters not generated
3 {%- endmacro %} 4 {%- endmacro %}
5 {% macro decl_protected_methods(field) -%}
6 {% if field.is_bit_field != 1 %}
shend 2017/04/19 03:41:29 You can do: "{% if field.is_bit_field %} ... {% el
nainar 2017/04/19 04:02:46 Yup. That is better.
7 const {{return_type(field)}} {{field.getter_method_name}}() const {
8 return {{decode(field, getter_expression(field))}};
9 }
10 {{field.type_name}}& {{field.mutable_method_name}}() {
11 return {{decode(field, getter_expression(field))}};
12 }
13 {% else %}
14 {{return_type(field)}} {{field.getter_method_name}}() const {
15 return {{decode(field, getter_expression(field))}};
16 }
17 {% endif %}
18 void {{field.setter_method_name}}(const {{field.type_name}}& v) {
19 {{setter_expression(field)}} = {{encode(field, "v")}};
20 }
21 {%- endmacro %}
22
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698