Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)
Patch Set: Adds protected methods for all fields that need it Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% from 'fields/field.tmpl' import encode, decode, return_type %} 1 {% from 'fields/field.tmpl' import encode, decode, getter_expression, setter_exp ression, return_type %}
2 {% macro decl_methods(field) -%} 2 {% macro decl_public_methods(field) -%}
3 inline static {{return_type(field)}} {{field.initial_method_name}}() { 3 inline static {{field.type_name}} {{field.initial_method_name}}() {
shend 2017/04/19 03:41:29 There's a lot of code duplication here now :( Mayb
nainar 2017/04/19 04:02:46 Will take a look at this in a later patch
4 return {{field.default_value}}; 4 return {{field.default_value}};
5 } 5 }
6 {{return_type(field)}} {{field.getter_method_name}}() const { 6 {{return_type(field)}} {{field.getter_method_name}}() const {
7 return {{decode(field, getter_expression(field))}};
8 }
9 void {{field.setter_method_name}}(const {{field.type_name}}& v) {
10 {{setter_expression(field)}} = {{encode(field, "v")}};
11 }
12 inline void {{field.resetter_method_name}}() {
13 {{setter_expression(field)}} = {{encode(field, field.default_value)}};
14 }
15 {%- endmacro %}
16
17 {% macro decl_protected_methods(field) -%}
18 inline static {{field.type_name}} {{field.initial_method_name}}() {
shend 2017/04/19 03:41:29 We probably won't need protected initial and reset
nainar 2017/04/19 04:02:46 Removed.
19 return {{field.default_value}};
20 }
21 {{return_type(field)}} {{field.getter_method_name}}() const {
7 return {{decode(field, field.name)}}; 22 return {{decode(field, field.name)}};
8 } 23 }
9 void {{field.setter_method_name}}({{field.type_name}} v) { 24 void {{field.setter_method_name}}({{field.type_name}} v) {
10 {{field.name}} = {{encode(field, "v")}}; 25 {{field.name}} = {{encode(field, "v")}};
11 } 26 }
12 inline void {{field.resetter_method_name}}() { 27 inline void {{field.resetter_method_name}}() {
13 {{field.name}} = {{encode(field, field.default_value)}}; 28 {{field.name}} = {{encode(field, field.default_value)}};
14 } 29 }
15 {%- endmacro %} 30 {%- endmacro %}
16
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698