Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)
Patch Set: Clean up nits prelanding Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2016 The Chromium Authors. All rights reserved. 2 # Copyright 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import math 6 import math
7 import sys 7 import sys
8 8
9 import json5_generator 9 import json5_generator
10 import template_expander 10 import template_expander
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 'Field role has to be exactly one of: property, inherited_flag, nonp roperty' 125 'Field role has to be exactly one of: property, inherited_flag, nonp roperty'
126 126
127 if not self.is_inherited_flag: 127 if not self.is_inherited_flag:
128 self.is_inherited = kwargs.pop('inherited') 128 self.is_inherited = kwargs.pop('inherited')
129 self.is_independent = kwargs.pop('independent') 129 self.is_independent = kwargs.pop('independent')
130 assert self.is_inherited or not self.is_independent, 'Only inherited fields can be independent' 130 assert self.is_inherited or not self.is_independent, 'Only inherited fields can be independent'
131 131
132 self.is_inherited_method_name = method_name(join_name(name_for_metho ds, 'is inherited')) 132 self.is_inherited_method_name = method_name(join_name(name_for_metho ds, 'is inherited'))
133 133
134 # Method names 134 # Method names
135 # TODO(nainar): Method name generation is inconsistent. Fix.
135 self.getter_method_name = getter_method_name 136 self.getter_method_name = getter_method_name
136 self.setter_method_name = setter_method_name 137 self.setter_method_name = setter_method_name
138 self.internal_getter_method_name = method_name(join_name(getter_method_n ame, 'Internal'))
139 self.internal_mutable_method_name = method_name(join_name('Mutable', nam e_for_methods, 'Internal'))
140 self.internal_setter_method_name = method_name(join_name(setter_method_n ame, 'Internal'))
137 self.initial_method_name = initial_method_name 141 self.initial_method_name = initial_method_name
138 self.resetter_method_name = method_name(join_name('Reset', name_for_meth ods)) 142 self.resetter_method_name = method_name(join_name('Reset', name_for_meth ods))
139 143
140 # If the size of the field is not None, it means it is a bit field 144 # If the size of the field is not None, it means it is a bit field
141 self.is_bit_field = self.size is not None 145 self.is_bit_field = self.size is not None
142 146
143 assert len(kwargs) == 0, 'Unexpected arguments provided to Field: ' + st r(kwargs) 147 assert len(kwargs) == 0, 'Unexpected arguments provided to Field: ' + st r(kwargs)
144 148
145 149
146 def _get_include_paths(properties): 150 def _get_include_paths(properties):
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 @template_expander.use_jinja('ComputedStyleBaseConstants.h.tmpl') 404 @template_expander.use_jinja('ComputedStyleBaseConstants.h.tmpl')
401 def generate_base_computed_style_constants(self): 405 def generate_base_computed_style_constants(self):
402 return { 406 return {
403 'properties': self._properties, 407 'properties': self._properties,
404 'enums': self._generated_enums, 408 'enums': self._generated_enums,
405 'fields': self._fields, 409 'fields': self._fields,
406 } 410 }
407 411
408 if __name__ == '__main__': 412 if __name__ == '__main__':
409 json5_generator.Maker(ComputedStyleBaseWriter).main() 413 json5_generator.Maker(ComputedStyleBaseWriter).main()
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698