third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl - Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)

Patch Set: suzyh@'s comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {% import 'fields/base.tmpl' as base %}	1 {% import 'fields/base.tmpl' as base %}

2 {% from 'fields/field.tmpl' import decode %}	2 {% from 'fields/field.tmpl' import decode %}

3 {% macro decl_methods(field) %}	3 {% macro decl_public_methods(field) %}

4 {{base.decl_methods(field)}}	4 {{base.decl_public_methods(field)}}

5 void {{field.setter_method_name}}({{field.type_name}}&& v) {	5 void {{field.setter_method_name}}({{field.type_name}}&& v) {

6 {{field.name}} = std::move({{decode(field, "v")}});	6 {{field.name}} = std::move({{decode(field, "v")}});

7 }	7 }

8 {% endmacro %}	8 {% endmacro %}

	9

	10 {% macro decl_protected_methods(field) -%}

	11 {{return_type}} {{field.internal_mutable_method_name}}() {
	shend 2017/04/20 03:57:55 I think this one can stay as {{field.type_name}}&. I think this one can stay as {{field.type_name}}&. External fields can never be a bit field. Hence, we would always be returning by reference. return_type is only useful when field can be a bit field or a non bit field (e.g. storage_only fields). nainar 2017/04/20 05:15:58 Done. Done.
	12 return {{decode(field, field.name)}};

	13 }

	14 {%- endmacro %}

OLD	NEW