third_party/WebKit/Source/build/scripts/make_computed_style_base.py - Issue 2826633002: Exploit sharing when comparing and copying groups in ComputedStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2826633002: Exploit sharing when comparing and copying groups in ComputedStyle. (Closed)

Patch Set: Add comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/template_expander.py » ('j') | third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

index 88bebe5598f36d604183f4e6120a5b9ee6200a1f..1f087f10c1dfe4ccab765f9084f4e9bc07a32ae8 100755

--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

@@ -425,7 +425,7 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):

'ComputedStyleBaseConstants.h': self.generate_base_computed_style_constants,

}

- @template_expander.use_jinja('ComputedStyleBase.h.tmpl')

+ @template_expander.use_jinja('ComputedStyleBase.h.tmpl', tests={'in': lambda a, b: a in b})

def generate_base_computed_style_h(self):

return {

'properties': self._properties,

@@ -434,7 +434,7 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):

'computed_style': self._root_group,

}

- @template_expander.use_jinja('ComputedStyleBase.cpp.tmpl')

+ @template_expander.use_jinja('ComputedStyleBase.cpp.tmpl', tests={'in': lambda a, b: a in b})

def generate_base_computed_style_cpp(self):

return {

'properties': self._properties,