Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 282663002: [Reland] Update DomDistillerJsUpdater and Roll DomDistillerJs (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
6 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

[Reland] Update DomDistillerJsUpdater and Roll DomDistillerJs New in this version: - Runs checklicenses.py against the code when running update_dom_distiller_js.sh - Picked up a couple new changes (including fix for checklicenses.py failure) Original Description: The update script should build `ant package` and copy the entire out/package directory. This moves the path to domdistiller.js to .../package/js so update that reference. The old (non-proto) API is still supported, so this keeps using that. Picked up changes: a15dc85 Change json protoc generation directory f9c9a21 Add GENERATED FILE header to proto-plugin files e99285f add *.pyc to .gitignore fdb023d Fix Proto module's path 44e9366 This adds two simple protoc plugins. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269972

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+721 lines, -499 lines) Patch
M components/dom_distiller/core/javascript/domdistiller.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/js/domdistiller.js View 1 1 chunk +0 lines, -493 lines 0 comments Download
A third_party/dom_distiller_js/package/js/domdistiller.js View 1 1 chunk +496 lines, -0 lines 0 comments Download
A third_party/dom_distiller_js/package/proto/dom_distiller.proto View 1 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/dom_distiller_js/package/proto_gen/third_party/dom_distiller_js/dom_distiller_json_converter.h View 1 1 chunk +184 lines, -0 lines 0 comments Download
M third_party/dom_distiller_js/update_domdistiller_js.sh View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
yfriedman: * https://codereview.chromium.org/282663002/diff/1/third_party/dom_distiller_js/update_domdistiller_js.sh File third_party/dom_distiller_js/update_domdistiller_js.sh (right): https://codereview.chromium.org/282663002/diff/1/third_party/dom_distiller_js/update_domdistiller_js.sh#newcode40 third_party/dom_distiller_js/update_domdistiller_js.sh:40: # Run checklicenses.py on the pulled files, ...
6 years, 7 months ago (2014-05-12 18:04:24 UTC) #1
Yaron
lgtm
6 years, 7 months ago (2014-05-12 18:12:53 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 7 months ago (2014-05-13 01:00:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/282663002/20001
6 years, 7 months ago (2014-05-13 01:01:38 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 02:27:56 UTC) #5
Message was sent while issue was closed.
Change committed as 269972

Powered by Google App Engine
This is Rietveld 408576698