Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2826623002: Increase tracing limit (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Increase tracing limit Increasing from 16 to 32 has a lot of nice small improvements and does not seem to affect compile time (within benchmark noise). BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/2955ecc79480135592f5f96a6c94422bca21ef70

Patch Set 1 #

Total comments: 1

Patch Set 2 : defaultValue: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sra1
3 years, 8 months ago (2017-04-18 17:49:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 8 months ago (2017-04-18 20:29:50 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2826623002/diff/1/pkg/compiler/lib/src/inferrer/node_tracer.dart File pkg/compiler/lib/src/inferrer/node_tracer.dart (right): https://codereview.chromium.org/2826623002/diff/1/pkg/compiler/lib/src/inferrer/node_tracer.dart#newcode81 pkg/compiler/lib/src/inferrer/node_tracer.dart:81: const int.fromEnvironment('dart2js.tracing.limit') ?? 32; maybe instead do: const int.fromEnvironment('...', ...
3 years, 8 months ago (2017-04-18 20:30:14 UTC) #4
sra1
3 years, 8 months ago (2017-04-18 22:00:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2955ecc79480135592f5f96a6c94422bca21ef70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698