Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc

Issue 2826423003: Expand Chrome OS ARC support to create one tree source per package (Closed)
Patch Set: Better fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
diff --git a/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc b/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b24c3dfa7fe4aafebb969ae961a923994e6cccac
--- /dev/null
+++ b/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
@@ -0,0 +1,137 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h"
+
+#include "base/command_line.h"
+#include "chromeos/chromeos_switches.h"
+#include "components/arc/arc_bridge_service.h"
+#include "components/arc/common/accessibility_helper.mojom.h"
+#include "components/exo/wm_helper.h"
+#include "components/exo/wm_helper_ash.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace arc {
+
+class ArcAccessibilityHelperBridgeTest : public testing::Test {
+ public:
+ ArcAccessibilityHelperBridgeTest() = default;
+
+ void SetUp() override {
+ wm_helper_ = base::MakeUnique<exo::WMHelperAsh>();
+ exo::WMHelper::SetInstance(wm_helper_.get());
+ bridge_service_ = base::MakeUnique<ArcBridgeService>();
+ accessibility_helper_bridge_ =
+ base::MakeUnique<ArcAccessibilityHelperBridge>(bridge_service_.get());
+ }
+
+ ArcAccessibilityHelperBridge* accessibility_helper_bridge() {
+ return accessibility_helper_bridge_.get();
+ }
+
+ private:
+ std::unique_ptr<exo::WMHelperAsh> wm_helper_;
+ std::unique_ptr<ArcBridgeService> bridge_service_;
+ std::unique_ptr<ArcAccessibilityHelperBridge> accessibility_helper_bridge_;
+
+ DISALLOW_COPY_AND_ASSIGN(ArcAccessibilityHelperBridgeTest);
+};
+
+TEST_F(ArcAccessibilityHelperBridgeTest, TaskLifecycle) {
+ ArcAccessibilityHelperBridge* helper_bridge = accessibility_helper_bridge();
+ const auto& package_to_tree = helper_bridge->package_name_to_tree_for_test();
+ const auto& package_to_ids =
+ helper_bridge->package_name_to_task_ids_for_test();
+
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(0U, package_to_ids.size());
+
+ helper_bridge->OnTaskCreated(1, "com.android.vending", "launch", "");
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(1U, package_to_ids.size());
+ auto it1 = package_to_ids.find("com.android.vending");
+ ASSERT_NE(package_to_ids.end(), it1);
+ ASSERT_EQ(1U, it1->second.size());
+ ASSERT_EQ(1U, it1->second.count(1));
+
+ helper_bridge->OnTaskCreated(2, "com.android.vending", "app", "");
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(1U, package_to_ids.size());
+ auto it2 = package_to_ids.find("com.android.vending");
+ ASSERT_NE(package_to_ids.end(), it2);
+ ASSERT_EQ(2U, it2->second.size());
+ ASSERT_EQ(1U, it2->second.count(1));
+ ASSERT_EQ(1U, it2->second.count(2));
+
+ helper_bridge->OnTaskCreated(3, "com.android.music", "app", "");
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(2U, package_to_ids.size());
+ auto it3 = package_to_ids.find("com.android.music");
+ ASSERT_NE(package_to_ids.end(), it3);
+ ASSERT_EQ(1U, it3->second.size());
+ ASSERT_EQ(1U, it3->second.count(3));
+
+ helper_bridge->OnTaskDestroyed(1);
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(2U, package_to_ids.size());
+ it1 = package_to_ids.find("com.android.vending");
+ ASSERT_NE(package_to_ids.end(), it1);
+ ASSERT_EQ(1U, it1->second.size());
+ ASSERT_EQ(0U, it1->second.count(1));
+ ASSERT_EQ(1U, it1->second.count(2));
+
+ helper_bridge->OnTaskDestroyed(2);
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(1U, package_to_ids.size());
+ it2 = package_to_ids.find("com.android.vending");
+ ASSERT_EQ(package_to_ids.end(), it2);
+
+ helper_bridge->OnTaskDestroyed(3);
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(0U, package_to_ids.size());
+}
+
+TEST_F(ArcAccessibilityHelperBridgeTest, AXTreeSourceLifetime) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ chromeos::switches::kEnableChromeVoxArcSupport);
+
+ ArcAccessibilityHelperBridge* helper_bridge = accessibility_helper_bridge();
+ const auto& package_to_tree = helper_bridge->package_name_to_tree_for_test();
+ const auto& package_to_ids =
+ helper_bridge->package_name_to_task_ids_for_test();
+
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(0U, package_to_ids.size());
+
+ helper_bridge->OnTaskCreated(1, "com.android.vending", "launch", "");
+ ASSERT_EQ(0U, package_to_tree.size());
+ ASSERT_EQ(1U, package_to_ids.size());
+ auto it1 = package_to_ids.find("com.android.vending");
+ ASSERT_NE(package_to_ids.end(), it1);
+ ASSERT_EQ(1U, it1->second.size());
+ ASSERT_EQ(1U, it1->second.count(1));
+
+ auto event = arc::mojom::AccessibilityEventData::New();
+ event->sourceId = 1;
+ event->eventType = arc::mojom::AccessibilityEventType::VIEW_FOCUSED;
+ event->nodeData.push_back(arc::mojom::AccessibilityNodeInfoData::New());
+ event->nodeData[0]->id = 1;
+ event->nodeData[0]->stringProperties =
+ std::unordered_map<arc::mojom::AccessibilityStringProperty,
+ std::string>();
+ event->nodeData[0]->stringProperties.value().insert(
+ std::make_pair(arc::mojom::AccessibilityStringProperty::PACKAGE_NAME,
+ "com.android.vending"));
+
+ // Task 1 is not current; gets rejected.
+ helper_bridge->OnAccessibilityEvent(event.Clone());
+ ASSERT_EQ(0U, package_to_tree.size());
+
+ // Task 1 is now current.
+ helper_bridge->OnTaskSetActive(1);
+ helper_bridge->OnAccessibilityEvent(event.Clone());
+ ASSERT_EQ(1U, package_to_tree.size());
+}
+
+} // namespace arc

Powered by Google App Engine
This is Rietveld 408576698