Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2826393004: v8binding: Makes Location's wrapper objects alive, really. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.h ('k') | third_party/WebKit/Source/core/frame/Location.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp
index 64c5d4e0c5a21d7aeca844ab1cc25b171e6180e1..31c5e99cfc4d1b346f5fe349ddf62a1d58ec4fa5 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp
@@ -34,6 +34,7 @@ namespace blink {
DOMWindow::DOMWindow(Frame& frame)
: frame_(frame),
window_proxy_manager_(frame.GetWindowProxyManager()),
+ location_(this, nullptr),
window_is_closing_(false) {}
DOMWindow::~DOMWindow() {
@@ -465,4 +466,10 @@ DEFINE_TRACE(DOMWindow) {
EventTargetWithInlineData::Trace(visitor);
}
+DEFINE_TRACE_WRAPPERS(DOMWindow) {
+ visitor->TraceWrappers(location_);
+
haraken 2017/04/21 11:49:52 Nit: Remove the empty line.
Yuki 2017/04/26 12:10:11 Done.
+ EventTargetWithInlineData::TraceWrappers(visitor);
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.h ('k') | third_party/WebKit/Source/core/frame/Location.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698