bluetooth: Make in progress errors consistent across android

device/bluetooth/bluetooth_remote_gatt_characteristic.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_H_
 
 #include <stdint.h>
 
 #include <queue>
@@ skipping 101 matching lines @@
   // the characteristic's new value.
   //
   // To stop the flow of notifications, simply call the Stop method on the
   // BluetoothGattNotifySession object that you received in |callback|.
   virtual void StartNotifySession(const NotifySessionCallback& callback,
                                   const ErrorCallback& error_callback);
 
   // Sends a read request to a remote characteristic to read its value.
   // |callback| is called to return the read value on success and
   // |error_callback| is called for failures.
-  virtual void ReadRemoteCharacteristic(
+  // If there are any other GATT operations in progress this will fail
+  // with BluetoothRemoteGattService::GATT_ERROR_IN_PROGRESS. This currently
+  // only happens on Android.
+  // TODO(crbug.com/657921): Return in progress error on all platforms.
+  virtual void ReadRemoteCharacteristic(const ValueCallback& callback,
+                                        const ErrorCallback& error_callback);
+  // TODO(crbug.com/657921): Make pure virtual once all platform implement it.
+  virtual void ReadRemoteCharacteristicImpl(
       const ValueCallback& callback,
-      const ErrorCallback& error_callback) = 0;
+      const ErrorCallback& error_callback){};
 
   // Sends a write request to a remote characteristic with the value |value|.
   // |callback| is called to signal success and |error_callback| for failures.
   // This method only applies to remote characteristics and will fail for those
   // that are locally hosted.
-  virtual void WriteRemoteCharacteristic(
+  // If there are any other GATT operations in progress this will fail
+  // with BluetoothRemoteGattService::GATT_ERROR_IN_PROGRESS. This currently
+  // only happens on Android.
+  // TODO(crbug.com/657921): Return in progress error on all platforms.
+  virtual void WriteRemoteCharacteristic(const std::vector<uint8_t>& value,
+                                         const base::Closure& callback,
+                                         const ErrorCallback& error_callback);
+  // TODO(crbug.com/657921): Make pure virtual once all platform implement it.
+  virtual void WriteRemoteCharacteristicImpl(
       const std::vector<uint8_t>& value,
       const base::Closure& callback,
-      const ErrorCallback& error_callback) = 0;
+      const ErrorCallback& error_callback){};
 
  protected:
   BluetoothRemoteGattCharacteristic();
   ~BluetoothRemoteGattCharacteristic() override;
 
+  bool HasPendingGattOperation();
+  void SetPendingGattOperation(bool pending);
+
   // Writes to the Client Characteristic Configuration descriptor to enable
   // notifications/indications. This method is meant to be called from
   // StartNotifySession and should contain only the code necessary to start
   // listening to characteristic notifications on a particular platform.
   virtual void SubscribeToNotifications(
       BluetoothRemoteGattDescriptor* ccc_descriptor,
       const base::Closure& callback,
       const ErrorCallback& error_callback) = 0;
 
   // Writes to the Client Characteristic Configuration descriptor to disable
@@ skipping 81 matching lines @@
   std::set<BluetoothGattNotifySession*> notify_sessions_;
 
   base::WeakPtrFactory<BluetoothRemoteGattCharacteristic> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristic);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_H_