Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h

Issue 2826373002: Move CompositionUnderlineVectorBuilder.* from web/ -> core/editing/. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h
diff --git a/third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.h b/third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h
similarity index 94%
rename from third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.h
rename to third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h
index a73bf86f47056b0d1cdec37ab18c160cd5d3ae09..f34cfadd955017e72cadf46166fa6e15ab534fb2 100644
--- a/third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.h
+++ b/third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h
@@ -31,6 +31,7 @@
#ifndef CompositionUnderlineVectorBuilder_h
#define CompositionUnderlineVectorBuilder_h
+#include "core/CoreExport.h"
#include "core/editing/CompositionUnderline.h"
#include "platform/wtf/Vector.h"
#include "public/platform/WebVector.h"
@@ -41,7 +42,8 @@ namespace blink {
// This classes are used for converting from WebVector<WebCompositionUnderline>
haraken 2017/04/20 07:25:50 This class is... (Nit: You could consider putting
slangley 2017/04/21 00:07:15 Done. TBH I'm from the one class -> one file scho
haraken 2017/04/21 06:18:54 I don't know. We normally create one file per clas
// to Vector<CompositionUnderline>.
-class CompositionUnderlineVectorBuilder : public Vector<CompositionUnderline> {
+class CORE_EXPORT CompositionUnderlineVectorBuilder
+ : public Vector<CompositionUnderline> {
public:
CompositionUnderlineVectorBuilder(const WebVector<WebCompositionUnderline>&);
};

Powered by Google App Engine
This is Rietveld 408576698